Bug 112687 - [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
Summary: [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-19 06:12 PDT by Sudarsana Nagineni (babu)
Modified: 2013-03-20 05:28 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.13 KB, patch)
2013-03-19 07:30 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2013-03-19 06:12:36 PDT 
SearchBar at the bottom of the window should not be visible by default when MiniBrowser opened.
Comment 1 Sudarsana Nagineni (babu) 2013-03-19 07:30:08 PDT 
Created attachment 193824 [details]
Patch
Comment 2 Chris Dumez 2013-03-19 07:34:18 PDT 
Comment on attachment 193824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review

> Tools/MiniBrowser/efl/main.c:1475
> +    search_box_hide(window);

Does it still work if we move this line before the evas_object_show(window->elm_window) one?
Comment 3 Sudarsana Nagineni (babu) 2013-03-19 07:38:28 PDT 
Comment on attachment 193824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review

>> Tools/MiniBrowser/efl/main.c:1475
>> +    search_box_hide(window);
> 
> Does it still work if we move this line before the evas_object_show(window->elm_window) one?

No. I tried already :)
Comment 4 Mikhail Pozdnyakov 2013-03-19 08:00:15 PDT 
Comment on attachment 193824 [details]
Patch

LGTM :)
Comment 5 Chris Dumez 2013-03-19 08:01:00 PDT 
Comment on attachment 193824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193824&action=review

>>> Tools/MiniBrowser/efl/main.c:1475
>>> +    search_box_hide(window);
>> 
>> Does it still work if we move this line before the evas_object_show(window->elm_window) one?
> 
> No. I tried already :)

Ok, then LGTM :)
Comment 6 Jinwoo Song 2013-03-19 16:55:35 PDT 
LGTM. Thanks, I missed it. :)
Comment 7 WebKit Review Bot 2013-03-20 05:28:45 PDT 
Comment on attachment 193824 [details]
Patch

Clearing flags on attachment: 193824

Committed r146332: <http://trac.webkit.org/changeset/146332>
Comment 8 WebKit Review Bot 2013-03-20 05:28:48 PDT 
All reviewed patches have been landed.  Closing bug.