Bug 112683 - [BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
Summary: [BlackBerry] MathExtras: macros defined in math.h conflict with the real func...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-03-19 04:57 PDT by Alberto Garcia
Modified: 2013-04-08 18:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2013-03-19 04:59 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-19 04:57:47 PDT 
After calls to signbit and friends were prefixed with std:: in
r143232, the BlackBerry port no longer compiles.

The reason are the signbit / isnan / isinf / isfinite macros defined
in math.h.

They should be removed in order to use real functions instead.
Comment 1 Alberto Garcia 2013-03-19 04:59:46 PDT 
Created attachment 193796 [details]
Patch
Comment 2 Alberto Garcia 2013-04-05 01:07:18 PDT 
Ping
Comment 3 WebKit Commit Bot 2013-04-08 18:26:21 PDT 
Comment on attachment 193796 [details]
Patch

Clearing flags on attachment: 193796

Committed r147972: <http://trac.webkit.org/changeset/147972>
Comment 4 WebKit Commit Bot 2013-04-08 18:26:23 PDT 
All reviewed patches have been landed.  Closing bug.