Bug 112668 – [Qt] New fast/text/word-space-with-kerning-3.html fails on Qt.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ádám Kallai]

The new layout test fast/text/word-space-with-kerning-3.html is failing after http://trac.webkit.org/changeset/146087.

diff:

http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r146183%20(49292)/fast/text/word-space-with-kerning-3-diffs.html

I will skip it.

[Ádám Kallai]

Skipped in: http://trac.webkit.org/changeset/146194/trunk/LayoutTests/platform/qt/TestExpectations

[Dean Jackson]

This seems like an actual bug in the layout system. Is kerning enabled on QT?

If so, then there is definitely a bug. The two pieces of content should be identical.

If not, then I'm not sure how they could be different :)

[Allan Sandfeld Jensen]

I think kerning might be always on in the complex font path in Qt. I have a patch to fix that I will see if that fixes it.

[Allan Sandfeld Jensen]

Created attachment 194018 [details]
Patch

Make complex font path respect WebCore kerning setting

[Allan Sandfeld Jensen]

Committed r146331: <http://trac.webkit.org/changeset/146331>

[WebKit Review Bot]

Re-opened since this is blocked by bug 112795

[Allan Sandfeld Jensen]

The test-case works with Qt 5.1 because both cases goes through the fast font path. There does however seem to be a problem with word-spacing working differently in fast and complex path. Possibly we need to fix the same bug in the Qt complex path that this test was introduced to test in the fast path.

[Allan Sandfeld Jensen]

Created attachment 194048 [details]
Patch

Second try, this time verified it works when the complex font path is used.

[Allan Sandfeld Jensen]

Created attachment 194076 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 194076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194076&action=review

> Source/WebCore/platform/graphics/qt/FontQt.cpp:238
> -    initFormatForTextLayout(&layout);
> +    initFormatForTextLayout(&layout, run);
>      QTextLine line = setupLayout(&layout, run);

Maybe you can do this in setupLayout instead? You don't seem to be using any Font member for this logic, and initFormatForTextLayout isn't a fitting name anymore with this.

> Source/WebCore/platform/graphics/qt/FontQt.cpp:260
> +    if (!range.length)
> +        return;

Maybe this is the reason why, but I'm not quite well following that part.

[Allan Sandfeld Jensen]

Created attachment 194088 [details]
Patch

Slight clean-up

[Pierre Rossi]

Comment on attachment 194088 [details]
Patch

Me gusta !

[Allan Sandfeld Jensen]

Comment on attachment 194088 [details]
Patch

Clearing flags on attachment: 194088

Committed r146630: <http://trac.webkit.org/changeset/146630>

[Allan Sandfeld Jensen]

All reviewed patches have been landed.  Closing bug.

[Zoltan Arvai]

After the patch 8 test started asserting on Qt debug bots.
https://bugs.webkit.org/show_bug.cgi?id=113179