WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112647
Dump icon change events in the icon-url-property test.
https://bugs.webkit.org/show_bug.cgi?id=112647
Summary
Dump icon change events in the icon-url-property test.
David Levin
Reported
2013-03-18 17:48:40 PDT
Dump icon change events in the icon-url-property test.
Attachments
Patch
(1.84 KB, patch)
2013-03-18 17:49 PDT
,
David Levin
no flags
Details
Formatted Diff
Diff
Patch
(2.03 KB, patch)
2013-03-18 18:41 PDT
,
David Levin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2013-03-18 17:49:17 PDT
Created
attachment 193706
[details]
Patch
David Levin
Comment 2
2013-03-18 18:41:09 PDT
Created
attachment 193713
[details]
Patch
WebKit Review Bot
Comment 3
2013-03-18 20:02:50 PDT
Comment on
attachment 193713
[details]
Patch Clearing flags on attachment: 193713 Committed
r146173
: <
http://trac.webkit.org/changeset/146173
>
WebKit Review Bot
Comment 4
2013-03-18 20:02:53 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 5
2013-03-18 20:55:33 PDT
This broke fast/dom/icon-url-property.html on Mac:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r146173%20(10545)/results.html
http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r146173%20(8996)/results.html
Simon Fraser (smfr)
Comment 6
2013-03-18 20:59:51 PDT
Reopen for Mac fixing, since I'm marking as an expected failure. Note that WTR on Mac doesn't appear to support testRunner.dumpIconChanges().
Simon Fraser (smfr)
Comment 7
2013-03-18 21:03:29 PDT
Marked as failing in
https://trac.webkit.org/r146176
David Levin
Comment 8
2013-03-18 21:08:57 PDT
Thanks. Sadness that
r122806
removed this call and allowed this to happen. I guess I'll add a special baseline for mac and check for the existance of this method.
David Levin
Comment 9
2013-03-18 22:57:51 PDT
Moved OSX fix to dependent bug rather than put more than one patch in the same bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug