Bug 112636 - [chromium] build xdisplaycheck when building DRT
Summary: [chromium] build xdisplaycheck when building DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-18 16:13 PDT by Dirk Pranke
Modified: 2013-04-06 17:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2013-03-18 16:16 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
fix tab characters (1.61 KB, patch)
2013-03-18 16:23 PDT, Dirk Pranke
benjamin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2013-03-18 16:13:59 PDT
[chromium] build xdisplaycheck when building DRT
Comment 1 Dirk Pranke 2013-03-18 16:16:57 PDT
Created attachment 193681 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-18 16:20:57 PDT
Attachment 193681 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp']" exit_code: 1
Tools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Tools/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dirk Pranke 2013-03-18 16:23:32 PDT
Created attachment 193684 [details]
fix tab characters
Comment 4 Dirk Pranke 2013-03-18 16:24:48 PDT
Committed r146148: <http://trac.webkit.org/changeset/146148>