112635 – MessagePortChannel::EventData should not be exposed

Bug 112635 - MessagePortChannel::EventData should not be exposed

Summary: MessagePortChannel::EventData should not be exposed

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alexey Proskuryakov

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-03-18 15:47 PDT by Alexey Proskuryakov
Modified:	2013-03-18 16:55 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
proposed patch (15.02 KB, patch) 2013-03-18 15:52 PDT, Alexey Proskuryakov	ggaren: review+ webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
with chromium build fix (15.04 KB, patch) 2013-03-18 16:07 PDT, Alexey Proskuryakov	webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexey Proskuryakov 2013-03-18 15:47:01 PDT

MessagePortChannel::EventData is an implementation detail that's only needed to store events in MessageQueue.

Comment 1 Alexey Proskuryakov 2013-03-18 15:52:59 PDT

Created attachment 193676 [details]
proposed patch

Comment 2 Geoffrey Garen 2013-03-18 15:57:33 PDT

Comment on attachment 193676 [details]
proposed patch

r=me

Comment 3 WebKit Review Bot 2013-03-18 16:04:41 PDT

Comment on attachment 193676 [details]
proposed patch

Attachment 193676 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17136536

Comment 4 Alexey Proskuryakov 2013-03-18 16:07:58 PDT

Created attachment 193678 [details]
with chromium build fix

Comment 5 WebKit Review Bot 2013-03-18 16:49:13 PDT

Comment on attachment 193678 [details]
with chromium build fix

Rejecting attachment 193678 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'validate-changelog', '--non-interactive', 193678, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Geoff Garen found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-commit-queue.appspot.com/results/17216396

Comment 6 Alexey Proskuryakov 2013-03-18 16:55:02 PDT

Oh really?

Committed <http://trac.webkit.org/changeset/146151>.