Bug 112628 - Implement canvas getContext attributes (e.g., { alpha: false } )
Summary: Implement canvas getContext attributes (e.g., { alpha: false } )
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
: 225191 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-03-18 14:45 PDT by Stephen White
Modified: 2021-05-02 04:09 PDT (History)
24 users (show)

See Also:


Attachments
Patch (37.57 KB, patch)
2013-03-18 14:45 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Patch (37.10 KB, patch)
2013-03-22 18:06 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Patch (37.18 KB, patch)
2013-03-22 20:14 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Patch (39.05 KB, patch)
2013-03-22 23:10 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Patch (38.99 KB, patch)
2013-03-25 10:54 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64 (972.09 KB, application/zip)
2013-03-25 17:49 PDT, WebKit Review Bot
no flags Details
Patch (39.01 KB, patch)
2013-04-04 11:25 PDT, Stephen White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2013-03-18 14:45:00 PDT
Implement canvas.getContext('2d', { alpha: none })
Comment 1 Stephen White 2013-03-18 14:45:26 PDT
Created attachment 193658 [details]
Patch
Comment 2 Stephen White 2013-03-18 14:46:00 PDT
This is not marked for review, since the feature is under discussion.
Comment 3 Stephen White 2013-03-22 18:06:57 PDT
Created attachment 194676 [details]
Patch
Comment 4 Stephen White 2013-03-22 20:14:02 PDT
Created attachment 194683 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-22 21:25:24 PDT
Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17141604
Comment 6 WebKit Review Bot 2013-03-22 21:27:21 PDT
Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17303008
Comment 7 Peter Beverloo (cr-android ews) 2013-03-22 21:50:54 PDT
Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17292087
Comment 8 Build Bot 2013-03-22 21:59:22 PDT
Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17293150
Comment 9 WebKit Review Bot 2013-03-22 22:04:56 PDT
Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17298094
Comment 10 WebKit Review Bot 2013-03-22 22:34:14 PDT
Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17298096
Comment 11 Peter Beverloo (cr-android ews) 2013-03-22 22:54:11 PDT
Comment on attachment 194683 [details]
Patch

Attachment 194683 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17141623
Comment 12 Stephen White 2013-03-22 23:10:47 PDT
Created attachment 194692 [details]
Patch
Comment 13 Elliott Sprehn 2013-03-23 19:27:40 PDT
This really needs to be opaque: true. I mean we're even calling it isOpaque in our own code! The test is opaque-....html and so on. Clearly the naming is wrong if we're not using it ourselves.
Comment 14 Stephen White 2013-03-24 07:46:44 PDT
(In reply to comment #13)
> This really needs to be opaque: true. I mean we're even calling it isOpaque in our own code! The test is opaque-....html and so on. Clearly the naming is wrong if we're not using it ourselves.

That's mostly due to it being a modification of the other patch (<canvas opaque>).  The naming here is intended to match WebGL.  Will rename the code while we discuss it.
Comment 15 Stephen White 2013-03-25 10:54:52 PDT
Created attachment 194887 [details]
Patch
Comment 16 WebKit Review Bot 2013-03-25 17:48:54 PDT
Comment on attachment 194887 [details]
Patch

Attachment 194887 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17203597

New failing tests:
canvas/philip/tests/2d.composite.uncovered.nocontext.source-out.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.pattern.basic.nocontext.html
canvas/philip/tests/2d.composite.uncovered.nocontext.source-in.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.source-out.html
canvas/philip/tests/2d.composite.uncovered.nocontext.destination-in.html
canvas/philip/tests/2d.composite.uncovered.nocontext.copy.html
canvas/philip/tests/2d.pattern.basic.nocontext.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/image-load-overflow-scrollbars.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-in.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-atop.html
platform/chromium/virtual/softwarecompositing/overflow/image-load-overflow-scrollbars.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.source-in.html
canvas/philip/tests/2d.composite.uncovered.nocontext.destination-atop.html
compositing/overflow/image-load-overflow-scrollbars.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.composite.uncovered.nocontext.copy.html
Comment 17 WebKit Review Bot 2013-03-25 17:49:00 PDT
Created attachment 194965 [details]
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 18 Stephen White 2013-04-04 11:25:38 PDT
Created attachment 196497 [details]
Patch
Comment 19 Brent Fulgham 2016-03-21 17:15:03 PDT
Dean, is this something we should be looking at for Canvas? This is some old code, so perhaps it's not relevant anymore?
Comment 20 Sam Weinig 2021-05-01 08:38:13 PDT
*** Bug 225191 has been marked as a duplicate of this bug. ***