Bug 112627 - MessagePort::disentangle() takes an ExceptionCode argument without any need
Summary: MessagePort::disentangle() takes an ExceptionCode argument without any need
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-18 14:36 PDT by Alexey Proskuryakov
Modified: 2013-03-18 15:24 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (5.34 KB, patch)
2013-03-18 14:39 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-03-18 14:36:44 PDT 
MessagePort::disentangle() is called in two places. One has ASSERT_NO_EXCEPTION, and another fails to check the exception, but clearly cannot get one.

This function is also not exposed to bindings.
Comment 1 Alexey Proskuryakov 2013-03-18 14:39:15 PDT 
Created attachment 193657 [details]
proposed patch
Comment 2 Geoffrey Garen 2013-03-18 14:50:08 PDT 
Comment on attachment 193657 [details]
proposed patch

r=me
Comment 3 WebKit Review Bot 2013-03-18 15:24:39 PDT 
Comment on attachment 193657 [details]
proposed patch

Clearing flags on attachment: 193657

Committed r146130: <http://trac.webkit.org/changeset/146130>
Comment 4 WebKit Review Bot 2013-03-18 15:24:42 PDT 
All reviewed patches have been landed.  Closing bug.