RESOLVED FIXED 112603
[chromium] fast/innerHTML/innerHTML-iframe.html is flaky 
https://bugs.webkit.org/show_bug.cgi?id=112603
Summary [chromium] fast/innerHTML/innerHTML-iframe.html is flaky
Kenneth Russell
Reported 2013-03-18 11:37:13 PDT
Layout test fast/innerHTML/innerHTML-iframe.html is flaky on all platforms. See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&showAllRuns=true&showExpectations=true&tests=fast%2FinnerHTML%2FinnerHTML-iframe.html Seems strange that the onload handler wouldn't be able to reference document.body. Could the new multithreaded parser have something to do with these failures?
Attachments
Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-03-18 12:06:40 PDT
Hmm, I thought I fixed the document.body flake in r145857 but it looks like the setTimeout is still racing with onload. The failing diff now is: TypeError: Cannot set property 'innerHTML' of null PASS: body and iframe cleared without crashing. which means the setTimeout() blew away <div id="x"> before the onload fired.
James Robinson
Comment 2 2013-03-18 13:28:15 PDT
Perhaps the right fix is to set the timeout from inside the onload handler so it always happens after the .innerHTML.
Kenneth Russell
Comment 3 2013-03-18 13:54:00 PDT
Is the existing pattern in the test supposed to be guaranteed to work though?
James Robinson
Comment 4 2013-03-18 14:00:24 PDT
No, it's racy.
Kenneth Russell
Comment 5 2013-03-18 14:06:30 PDT
OK. I'll update the test.
Kenneth Russell
Comment 6 2013-03-18 14:38:42 PDT
Fixed the test in http://trac.webkit.org/changeset/146126 .
Note You need to log in before you can comment on or make changes to this bug.