Bug 112587 - [CSS Exclusions] shape outside segments not properly calculated for ellipses
Summary: [CSS Exclusions] shape outside segments not properly calculated for ellipses
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL: http://dev.w3.org/csswg/css3-exclusio...
Depends on:
Blocks: 98664
  Show dependency treegraph
Reported: 2013-03-18 09:56 PDT by Bem Jones-Bey
Modified: 2013-03-29 14:11 PDT (History)
5 users (show)

See Also:

Example of the bug (1.36 KB, text/html)
2013-03-18 09:56 PDT, Bem Jones-Bey
no flags Details
Expanded test case (2.38 KB, text/html)
2013-03-28 11:26 PDT, Hans Muller
no flags Details
Patch (10.44 KB, patch)
2013-03-28 16:07 PDT, Bem Jones-Bey
jchaffraix: review+
Details | Formatted Diff | Diff
Patch (10.66 KB, patch)
2013-03-29 13:38 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-03-18 09:56:07 PDT
Created attachment 193587 [details]
Example of the bug

With some ellipses, the segment value is too short, allowing text to intrude into the shape.
Comment 1 Hans Muller 2013-03-28 11:26:01 PDT
Created attachment 195605 [details]
Expanded test case

The problem occurs for all Exclusion shapes and only occurs when the shape's logicalTop is non-zero, which causes the float's bounds to be adjusted.  The new test case demos the problem for circle, ellipse, and polygon.
Comment 2 Bem Jones-Bey 2013-03-28 16:07:08 PDT
Created attachment 195667 [details]

Fix coordinate calculation
Comment 3 Julien Chaffraix 2013-03-29 13:28:30 PDT
Comment on attachment 195667 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=195667&action=review

> LayoutTests/ChangeLog:14
> +        in the right place, we just want to simulate the shape's effect.

I would see that as a comment in the code as it's useful to understand the testing code.
Comment 4 Bem Jones-Bey 2013-03-29 13:38:54 PDT
Created attachment 195789 [details]

Add requested comment
Comment 5 WebKit Review Bot 2013-03-29 14:11:19 PDT
Comment on attachment 195789 [details]

Clearing flags on attachment: 195789

Committed r147250: <http://trac.webkit.org/changeset/147250>
Comment 6 WebKit Review Bot 2013-03-29 14:11:23 PDT
All reviewed patches have been landed.  Closing bug.