Bug 112569 – Web Inspector: use individual samples to construct CPU profile flame chart

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Now we build the chart based on the aggregated top-down tree. Using samples stream for that would allow to tie stack traces to the timeline.

[Yury Semikhatsky]

Created attachment 193554 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #1)
> Created an attachment (id=193554) [details]
> Patch

This patch depends on the V8 change: https://codereview.chromium.org/12919002/ which is not landed yet.

[Yury Semikhatsky]

Created attachment 193556 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 193556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193556&action=review

> Source/WebCore/inspector/front-end/FlameChart.js:166
> +        var nodeCount = samples.length;

it is intervalCount and it is not equal to samples.length
profileNodeCount <= intervalCount <= samplesCount
So the arrays will use more memory than actually needed.

BTW duration and startTime are integers now.

[WebKit Review Bot]

Comment on attachment 193556 [details]
Patch

Attachment 193556 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17160558

[WebKit Review Bot]

Comment on attachment 193556 [details]
Patch

Attachment 193556 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17205550

[Peter Beverloo (cr-android ews)]

Comment on attachment 193556 [details]
Patch

Attachment 193556 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17218396

[Build Bot]

Comment on attachment 193556 [details]
Patch

Attachment 193556 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17236083

New failing tests:
inspector/profiler/cpu-profiler-profile-removal.html

[Build Bot]

Comment on attachment 193556 [details]
Patch

Attachment 193556 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17201699

New failing tests:
inspector/profiler/cpu-profiler-profile-removal.html

[Build Bot]

Comment on attachment 193556 [details]
Patch

Attachment 193556 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17218466

New failing tests:
inspector/profiler/cpu-profiler-profile-removal.html

[Pavel Feldman]

Comment on attachment 193556 [details]
Patch

Please mind the test failures.

[Yury Semikhatsky]

Created attachment 194198 [details]
Patch for landing

[Yury Semikhatsky]

(In reply to comment #4)
> (From update of attachment 193556 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193556&action=review
> 
> > Source/WebCore/inspector/front-end/FlameChart.js:166
> > +        var nodeCount = samples.length;
> 
> it is intervalCount and it is not equal to samples.length
> profileNodeCount <= intervalCount <= samplesCount
> So the arrays will use more memory than actually needed.
> 
> BTW duration and startTime are integers now.

Fixed.

[Ilya Tikhonovsky]

Comment on attachment 194198 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=194198&action=review

> Source/WebCore/inspector/front-end/FlameChart.js:216
> +                ++index;

it has to be replaced with entries.length;

[Yury Semikhatsky]

Created attachment 194503 [details]
Patch

[Yury Semikhatsky]

Committed r146587: <http://trac.webkit.org/changeset/146587>