Bug 112565 - [GTK] Add padding to all public class structs for future expansion without breaking ABI
Summary: [GTK] Add padding to all public class structs for future expansion without br...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2013-03-18 06:53 PDT by Carlos Garcia Campos
Modified: 2013-05-15 11:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (20.25 KB, patch)
2013-03-18 06:55 PDT, Carlos Garcia Campos 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-03-18 06:53:37 PDT 
I think we can use 4 pointers for most of the classes that are unlikely to grow and 8 for WebKitWebView and WebKitWebContext.
Comment 1 Carlos Garcia Campos 2013-03-18 06:55:31 PDT 
Created attachment 193551 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-03-18 07:55:04 PDT 
Comment on attachment 193551 [details]
Patch

Sounds good to me
Comment 3 Carlos Garcia Campos 2013-05-15 02:16:03 PDT 
I had forgotten this patch. It's very important to land this before making the first unstable release. Please, owners, this should be trivial to review and has already been approved by Gustavo.
Comment 4 Carlos Garcia Campos 2013-05-15 11:11:02 PDT 
Committed r150130: <http://trac.webkit.org/changeset/150130>