RESOLVED FIXED112563
HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar 
https://bugs.webkit.org/show_bug.cgi?id=112563
Summary HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar
Allan Sandfeld Jensen
Reported 2013-03-18 06:17:58 PDT
To preserve original behavior HitTestRequest::AllowFrameScrollbars only tested the scrollbars of child frame when introduced. This is however both confusing and unnecessary. The one remaining call site using the options also needs to hit test the main frame, and is currently forced to do that after a hit-test with HitTestRequest::AllowFrameScrollbars.
Attachments
Patch (4.43 KB, patch)
2013-03-18 06:22 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-03-18 06:22:13 PDT
Created attachment 193547 [details] Patch
Antonio Gomes
Comment 2 2013-04-10 10:40:30 PDT
Comment on attachment 193547 [details] Patch Looks good. Could we use mock scrollbars to add some basic tests?
Allan Sandfeld Jensen
Comment 3 2013-04-10 11:24:33 PDT
(In reply to comment #2) > (From update of attachment 193547 [details]) > Looks good. Could we use mock scrollbars to add some basic tests? At this point it is just a refactoring and already covered by existing tests.
Allan Sandfeld Jensen
Comment 4 2013-04-11 02:16:07 PDT
Comment on attachment 193547 [details] Patch Clearing flags on attachment: 193547 Committed r148188: <http://trac.webkit.org/changeset/148188>
Allan Sandfeld Jensen
Comment 5 2013-04-11 02:16:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.