Bug 112560 – Fix unused parameter warnings in JITInlines.h

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Csaba Osztrogonác]

.../Source/JavaScriptCore/jit/JITInlines.h:147:48: warning: unused parameter 'insnSpace' [-Wunused-parameter]
.../Source/JavaScriptCore/jit/JITInlines.h:147:48: warning: unused parameter 'constSpace' [-Wunused-parameter]

This problem is come from the following very very old changesets:
- http://trac.webkit.org/changeset/47186/trunk/JavaScriptCore/jit/JITInlineMethods.h
- http://trac.webkit.org/changeset/83447/trunk/Source/JavaScriptCore/jit/JITInlineMethods.h

Fix is coming soon.

[Csaba Osztrogonác]

Created attachment 193537 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 193537 [details]
Patch

- I removed the redundant "#if defined(ASSEMBLER_HAS_CONSTANT_POOL) && ASSEMBLER_HAS_CONSTANT_POOL" 
guards, because beginUninterruptedSequence and endUninterruptedSequence are  inside this kind of guard.

- I added an "#ifndef NDEBUG" guard for endUninterruptedSequence function, because this 
function is for assertion check only and it is easiear to fix unused parameters in this way.
If I didn't use this guard, I had to use ASSERT for CPU(SH4) and ASSERT_UNUSED for !CPU(SH4).

[Csaba Osztrogonác]

ping?

[Gabor Loki]

Since I've done this a long time ago, I can give you an informal r+.
I guess Zoltan, Filip or Oliver can give you the final flag. ;)

[thouraya]

Hi,

I'm not authorized to edit the attachment
I give you an r+.
 

(In reply to comment #3)
> ping?


Regards,
Thouraya.

[Zoltan Herczeg]

Comment on attachment 193537 [details]
Patch

r=me

[Csaba Osztrogonác]

Comment on attachment 193537 [details]
Patch

Clearing flags on attachment: 193537

Committed r146869: <http://trac.webkit.org/changeset/146869>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.