Bug 112547 - [BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
Summary: [BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-03-18 02:58 PDT by Alberto Garcia
Modified: 2013-03-18 04:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2013-03-18 02:59 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-18 02:58:59 PDT 
frame->ownerElement() already returns an Element*, so the toElement()
call is unnecessary and breaks the build because of this code in
Element.h:

  // This will catch anyone doing an unnecessary cast.
  void toElement(const Element*);

This changed in r145818:

http://trac.webkit.org/changeset/145818/trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp
Comment 1 Alberto Garcia 2013-03-18 02:59:51 PDT 
Created attachment 193510 [details]
Patch
Comment 2 Antonio Gomes 2013-03-18 03:49:05 PDT 
Comment on attachment 193510 [details]
Patch

This file should just be completely removed at some point.
Comment 3 WebKit Review Bot 2013-03-18 03:54:41 PDT 
Comment on attachment 193510 [details]
Patch

Clearing flags on attachment: 193510

Committed r146051: <http://trac.webkit.org/changeset/146051>
Comment 4 WebKit Review Bot 2013-03-18 03:54:44 PDT 
All reviewed patches have been landed.  Closing bug.