RESOLVED FIXED Bug 112547
[BlackBerry] BackingStoreClient: remove unnecessary call to toElement() 
https://bugs.webkit.org/show_bug.cgi?id=112547
Summary [BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
Alberto Garcia
Reported 2013-03-18 02:58:59 PDT
frame->ownerElement() already returns an Element*, so the toElement() call is unnecessary and breaks the build because of this code in Element.h: // This will catch anyone doing an unnecessary cast. void toElement(const Element*); This changed in r145818: http://trac.webkit.org/changeset/145818/trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp
Attachments
Patch (1.43 KB, patch)
2013-03-18 02:59 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-18 02:59:51 PDT
Created attachment 193510 [details] Patch
Antonio Gomes
Comment 2 2013-03-18 03:49:05 PDT
Comment on attachment 193510 [details] Patch This file should just be completely removed at some point.
WebKit Review Bot
Comment 3 2013-03-18 03:54:41 PDT
Comment on attachment 193510 [details] Patch Clearing flags on attachment: 193510 Committed r146051: <http://trac.webkit.org/changeset/146051>
WebKit Review Bot
Comment 4 2013-03-18 03:54:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.