Bug 112545 - Web Inspector: [Settings] Register "?" shortcut.
Summary: Web Inspector: [Settings] Register "?" shortcut.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-18 02:43 PDT by Eugene Klyuchnikov
Modified: 2013-03-18 08:13 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2013-03-18 02:46 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2013-03-18 07:30 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2013-03-18 07:41 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2013-03-18 07:47 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-03-18 02:43:26 PDT 
"?" (show shortcuts page) is not mentioned on shortcuts page.
Comment 1 Eugene Klyuchnikov 2013-03-18 02:46:37 PDT 
Created attachment 193509 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-03-18 07:06:40 PDT 
Comment on attachment 193509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193509&action=review

> Source/WebCore/inspector/front-end/inspector.js:704
> +    section.addKey(shortcut.makeDescriptor("?"), WebInspector.UIString("Show this page"));

Show keyboard shortcuts help
Comment 3 Vsevolod Vlasov 2013-03-18 07:07:23 PDT 
Comment on attachment 193509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193509&action=review

>> Source/WebCore/inspector/front-end/inspector.js:704
>> +    section.addKey(shortcut.makeDescriptor("?"), WebInspector.UIString("Show this page"));
> 
> Show keyboard shortcuts help

Please note that F1 also shows this help page.
Comment 4 Eugene Klyuchnikov 2013-03-18 07:30:52 PDT 
Created attachment 193558 [details]
Patch
Comment 5 Eugene Klyuchnikov 2013-03-18 07:41:04 PDT 
Created attachment 193561 [details]
Patch
Comment 6 Eugene Klyuchnikov 2013-03-18 07:41:35 PDT 
Comment on attachment 193509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193509&action=review

>>> Source/WebCore/inspector/front-end/inspector.js:704
>>> +    section.addKey(shortcut.makeDescriptor("?"), WebInspector.UIString("Show this page"));
>> 
>> Show keyboard shortcuts help
> 
> Please note that F1 also shows this help page.

OK
Done.
Comment 7 Vsevolod Vlasov 2013-03-18 07:45:31 PDT 
Comment on attachment 193561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193561&action=review

> Source/WebCore/inspector/front-end/inspector.js:-678
> -    var keys = [

'var' should be here, not below.
Comment 8 Eugene Klyuchnikov 2013-03-18 07:47:12 PDT 
Created attachment 193563 [details]
Patch
Comment 9 Eugene Klyuchnikov 2013-03-18 07:49:48 PDT 
Comment on attachment 193561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193561&action=review

>> Source/WebCore/inspector/front-end/inspector.js:-678
>> -    var keys = [
> 
> 'var' should be here, not below.

surely. it is above =)
Comment 10 WebKit Review Bot 2013-03-18 08:13:33 PDT 
Comment on attachment 193563 [details]
Patch

Clearing flags on attachment: 193563

Committed r146066: <http://trac.webkit.org/changeset/146066>
Comment 11 WebKit Review Bot 2013-03-18 08:13:37 PDT 
All reviewed patches have been landed.  Closing bug.