Bug 112536 - ewk_settings_memory_cache_clear should clear JS garbage and release FastMalloc's free pages to OS
Summary: ewk_settings_memory_cache_clear should clear JS garbage and release FastMallo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-18 00:47 PDT by Jose Lejin PJ
Modified: 2013-03-20 04:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.81 KB, text/plain)
2013-03-18 03:29 PDT, Jose Lejin PJ
no flags Details
Patch (2.45 KB, patch)
2013-03-18 03:33 PDT, Jose Lejin PJ
no flags Details | Formatted Diff | Diff
WIP (17.63 KB, patch)
2013-03-19 02:47 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
WIP (28.21 KB, patch)
2013-03-19 04:59 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (2.59 KB, patch)
2013-03-20 03:08 PDT, Jose Lejin PJ
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lejin PJ 2013-03-18 00:47:12 PDT
ewk_settings_memory_cache_clear() should clear JS garbage and release FastMalloc's free pages to OS

In Qt recently patch landed https://bugs.webkit.org/show_bug.cgi?id=111094 / https://bugs.webkit.org/show_bug.cgi?id=111605.
Same logic applies to EFL also.
Comment 1 Jose Lejin PJ 2013-03-18 03:29:54 PDT
Created attachment 193515 [details]
Patch
Comment 2 Jose Lejin PJ 2013-03-18 03:33:03 PDT
Created attachment 193518 [details]
Patch
Comment 3 Hajime Morrita 2013-03-19 02:47:33 PDT
Created attachment 193770 [details]
WIP
Comment 4 Jose Lejin PJ 2013-03-19 03:20:07 PDT
Morrita is the patch related to this issue ? Please explain.
(In reply to comment #3)
> Created an attachment (id=193770) [details]
> WIP
Comment 5 Hajime Morrita 2013-03-19 04:59:38 PDT
Created attachment 193795 [details]
WIP
Comment 6 Hajime Morrita 2013-03-19 20:05:26 PDT
Comment on attachment 193795 [details]
WIP

Ooops. Uploaded to the wrong bug. Sorry for disturbance...
Comment 7 Jose Lejin PJ 2013-03-19 20:23:43 PDT
(In reply to comment #2)
> Created an attachment (id=193518) [details]
> Patch

Changed this to active patch.
Comment 8 Gyuyoung Kim 2013-03-20 02:13:15 PDT
Comment on attachment 193518 [details]
Patch

Looks good to me. Thanks.
Comment 9 Gyuyoung Kim 2013-03-20 02:15:10 PDT
Comment on attachment 193518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193518&action=review

> Source/WebKit/efl/ChangeLog:7
> +

Though this bug title represents patch, I prefer to write detail description here.
Comment 10 Jose Lejin PJ 2013-03-20 03:08:12 PDT
Created attachment 194010 [details]
Patch
Comment 11 Jose Lejin PJ 2013-03-20 03:09:34 PDT
(In reply to comment #9)
> (From update of attachment 193518 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193518&action=review
> 
> > Source/WebKit/efl/ChangeLog:7
> > +
> 
> Though this bug title represents patch, I prefer to write detail description here.

Thanks Kim. I updated changelog.
Comment 12 WebKit Review Bot 2013-03-20 04:07:09 PDT
Comment on attachment 194010 [details]
Patch

Clearing flags on attachment: 194010

Committed r146322: <http://trac.webkit.org/changeset/146322>
Comment 13 WebKit Review Bot 2013-03-20 04:07:15 PDT
All reviewed patches have been landed.  Closing bug.