Bug 112528 - Mediastream.ended should return true when all tracks were removed.
Summary: Mediastream.ended should return true when all tracks were removed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Li Yin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-17 19:34 PDT by Li Yin
Modified: 2013-03-18 02:30 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.36 KB, patch)
2013-03-17 20:33 PDT, Li Yin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Li Yin 2013-03-17 19:34:24 PDT 
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-ended
When all tracks have been removed, it should return true as well as all the tracks were ended.
Comment 1 Li Yin 2013-03-17 20:33:02 PDT 
Created attachment 193481 [details]
Patch
Comment 2 Kentaro Hara 2013-03-17 20:51:11 PDT 
Comment on attachment 193481 [details]
Patch

LGTM. Please wait for tommyw's comment before landing.
Comment 3 Li Yin 2013-03-17 21:36:53 PDT 
(In reply to comment #2)
> (From update of attachment 193481 [details])
> LGTM. Please wait for tommyw's comment before landing.

Okay, thanks for your review.
Comment 4 Tommy Widenflycht 2013-03-18 02:08:40 PDT 
Comment on attachment 193481 [details]
Patch

r+ from me too.
Comment 5 Kentaro Hara 2013-03-18 02:09:15 PDT 
Comment on attachment 193481 [details]
Patch

Thanks!
Comment 6 WebKit Review Bot 2013-03-18 02:30:27 PDT 
Comment on attachment 193481 [details]
Patch

Clearing flags on attachment: 193481

Committed r146046: <http://trac.webkit.org/changeset/146046>
Comment 7 WebKit Review Bot 2013-03-18 02:30:31 PDT 
All reviewed patches have been landed.  Closing bug.