Bug 112527 - INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
Summary: INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified All
: P2 Normal
Assignee: Kunihiko Sakamoto
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-17 18:22 PDT by Kunihiko Sakamoto
Modified: 2013-03-17 22:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (47.65 KB, patch)
2013-03-17 18:46 PDT, Kunihiko Sakamoto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kunihiko Sakamoto 2013-03-17 18:22:56 PDT 
Use min/max attributes of <input type=time> and <input type=datetime-local> to limit values selectable by step-up/down.
This is the last piece of the series of changes.
Comment 1 Kunihiko Sakamoto 2013-03-17 18:46:08 PDT 
Created attachment 193476 [details]
Patch
Comment 2 Kent Tamura 2013-03-17 22:14:07 PDT 
Comment on attachment 193476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193476&action=review

> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:67
> -DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document, FieldOwner& fieldOwner, int minimum, int maximum, const String& placeholder, const DateTimeNumericFieldElement::Parameters& parameters)
> +DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document, FieldOwner& fieldOwner, const Range& range, const Range& hardLimits, const String& placeholder, const DateTimeNumericFieldElement::Parameters& parameters)
>      : DateTimeFieldElement(document, fieldOwner)
>      , m_lastDigitCharTime(0)
>      , m_placeholder(placeholder)
> -    , m_range(minimum, maximum)
> +    , m_range(range)
> +    , m_hardLimits(hardLimits)

nit: We should have made this change before this bug to minimize the size of each patches.
Comment 3 WebKit Review Bot 2013-03-17 22:28:30 PDT 
Comment on attachment 193476 [details]
Patch

Clearing flags on attachment: 193476

Committed r146032: <http://trac.webkit.org/changeset/146032>
Comment 4 WebKit Review Bot 2013-03-17 22:28:32 PDT 
All reviewed patches have been landed.  Closing bug.