Bug 112527 – INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kunihiko Sakamoto]

Use min/max attributes of <input type=time> and <input type=datetime-local> to limit values selectable by step-up/down.
This is the last piece of the series of changes.

[Kunihiko Sakamoto]

Created attachment 193476 [details]
Patch

[Kent Tamura]

Comment on attachment 193476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193476&action=review

> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:67
> -DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document, FieldOwner& fieldOwner, int minimum, int maximum, const String& placeholder, const DateTimeNumericFieldElement::Parameters& parameters)
> +DateTimeNumericFieldElement::DateTimeNumericFieldElement(Document* document, FieldOwner& fieldOwner, const Range& range, const Range& hardLimits, const String& placeholder, const DateTimeNumericFieldElement::Parameters& parameters)
>      : DateTimeFieldElement(document, fieldOwner)
>      , m_lastDigitCharTime(0)
>      , m_placeholder(placeholder)
> -    , m_range(minimum, maximum)
> +    , m_range(range)
> +    , m_hardLimits(hardLimits)

nit: We should have made this change before this bug to minimize the size of each patches.

[WebKit Review Bot]

Comment on attachment 193476 [details]
Patch

Clearing flags on attachment: 193476

Committed r146032: <http://trac.webkit.org/changeset/146032>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.