REOPENED112524
[wk2] IconDatabase images should be decoded in the WebProcess 
https://bugs.webkit.org/show_bug.cgi?id=112524
Summary [wk2] IconDatabase images should be decoded in the WebProcess
Tim Horton
Reported 2013-03-17 16:10:41 PDT
<rdar://problem/10133914>
Attachments
preliminary (12.26 KB, patch)
2013-03-17 22:09 PDT, Tim Horton 		buildbot: commit-queue-
DetailsFormatted DiffDiff
patch (15.75 KB, patch)
2013-04-02 18:43 PDT, Tim Horton 		oliver: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-03-17 22:09:18 PDT
Created attachment 193489 [details] preliminary
Build Bot
Comment 2 2013-03-17 22:45:54 PDT
Comment on attachment 193489 [details] preliminary Attachment 193489 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17241001
Tim Horton
Comment 3 2013-04-02 18:43:44 PDT
Created attachment 196265 [details] patch
WebKit Review Bot
Comment 4 2013-04-02 18:45:09 PDT
Attachment 196265 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/loader/icon/IconDatabase.h', u'Source/WebCore/loader/icon/IconDatabaseBase.h', u'Source/WebCore/loader/icon/IconRecord.cpp', u'Source/WebCore/loader/icon/IconRecord.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/WebIconDatabase.cpp', u'Source/WebKit2/UIProcess/WebIconDatabase.h', u'Source/WebKit2/UIProcess/WebIconDatabase.messages.in', u'Source/WebKit2/WebProcess/IconDatabase/WebIconDatabaseProxy.cpp']" exit_code: 1 Source/WebKit2/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 5 2013-04-03 02:18:47 PDT
Comment on attachment 196265 [details] patch Attachment 196265 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17387164
Oliver Hunt
Comment 6 2013-04-09 10:42:01 PDT
Comment on attachment 196265 [details] patch r=me, but you need to fix windows build and death to all the tabs!
Tim Horton
Comment 7 2013-04-09 11:08:31 PDT
(In reply to comment #6) > (From update of attachment 196265 [details]) > r=me, but you need to fix windows build and death to all the tabs! Will do! And, yeah :( new machine, didn't have config yet.
Tim Horton
Comment 8 2013-04-09 12:03:59 PDT
http://trac.webkit.org/changeset/148034
WebKit Commit Bot
Comment 9 2013-04-11 13:48:56 PDT
Re-opened since this is blocked by bug 114463
Tim Horton
Comment 10 2013-04-15 17:23:41 PDT
(In reply to comment #0) > <rdar://problem/10133914> This is actually tracked by <rdar://problem/13657741>.
Note You need to log in before you can comment on or make changes to this bug.