Bug 112509 - Stack overflow occurs in Windows build on startup
Summary: Stack overflow occurs in Windows build on startup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 112572 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-03-16 18:21 PDT by Peter Nelson
Modified: 2013-03-18 12:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2013-03-16 18:34 PDT, Peter Nelson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Nelson 2013-03-16 18:21:22 PDT 
Currently in the Windows build, on startup, WebView::setSelectTrailingWhitespaceEnabled and WebView::setSmartInsertDeleteEnabled recursively call each other until a stack overflow occurs.

I believe this is a regression caused by changeset 145849 (http://trac.webkit.org/changeset/145849)
Comment 1 Peter Nelson 2013-03-16 18:34:19 PDT 
Created attachment 193451 [details]
Patch
Comment 2 Peter Nelson 2013-03-16 18:35:42 PDT 
Just made the conditional logic in these methods consistent with the corresponding methods in WebKit/mac/WebView/WebView.mm.
Comment 3 Alexey Proskuryakov 2013-03-18 10:59:59 PDT 
*** Bug 112572 has been marked as a duplicate of this bug. ***
Comment 4 Peter Nelson 2013-03-18 12:56:27 PDT 
This is now fixed: http://trac.webkit.org/changeset/146097