RESOLVED FIXED Bug 112508
Modernize fast/events/autoscroll.html 
https://bugs.webkit.org/show_bug.cgi?id=112508
Summary Modernize fast/events/autoscroll.html
Benjamin Poulain
Reported 2013-03-16 17:57:58 PDT
Modernize fast/events/autoscroll.html
Attachments
Patch (107.39 KB, patch)
2013-03-16 18:01 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (48.08 KB, patch)
2013-04-05 18:04 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-03-16 18:01:46 PDT
Created attachment 193450 [details] Patch
Jer Noble
Comment 2 2013-04-05 16:58:15 PDT
Comment on attachment 193450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193450&action=review Looks good! Small nit, which may not be worth picking: > LayoutTests/fast/events/no-scroll-on-input-text-selection.html:29 > + var h = ta.offsetTop - document.body.scrollTop + 10; > + eventSender.dragMode = false; > + eventSender.mouseMoveTo(20, h); > + eventSender.mouseDown(); > + eventSender.mouseMoveTo(20, h); > + eventSender.mouseMoveTo(100, h); Nit: these all seem a little magic numbery. There is some code in LayoutTests/media/media-controls.js to find the mid-point of a specified control. That may be useful here for this selection test.
Benjamin Poulain
Comment 3 2013-04-05 18:04:39 PDT
Created attachment 196711 [details] Patch
Benjamin Poulain
Comment 4 2013-04-05 20:32:14 PDT
Comment on attachment 196711 [details] Patch Clearing flags on attachment: 196711 Committed r147830: <http://trac.webkit.org/changeset/147830>
Benjamin Poulain
Comment 5 2013-04-05 20:32:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.