Bug 112508 - Modernize fast/events/autoscroll.html
Summary: Modernize fast/events/autoscroll.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-16 17:57 PDT by Benjamin Poulain
Modified: 2013-04-05 20:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (107.39 KB, patch)
2013-03-16 18:01 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (48.08 KB, patch)
2013-04-05 18:04 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-03-16 17:57:58 PDT 
Modernize fast/events/autoscroll.html
Comment 1 Benjamin Poulain 2013-03-16 18:01:46 PDT 
Created attachment 193450 [details]
Patch
Comment 2 Jer Noble 2013-04-05 16:58:15 PDT 
Comment on attachment 193450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193450&action=review

Looks good!  Small nit, which may not be worth picking:

> LayoutTests/fast/events/no-scroll-on-input-text-selection.html:29
> +                    var h = ta.offsetTop - document.body.scrollTop + 10;
> +                    eventSender.dragMode = false;
> +                    eventSender.mouseMoveTo(20, h);
> +                    eventSender.mouseDown();
> +                    eventSender.mouseMoveTo(20, h);
> +                    eventSender.mouseMoveTo(100, h);

Nit: these all seem a little magic numbery.  There is some code in LayoutTests/media/media-controls.js to find the mid-point of a specified control.  That may be useful here for this selection test.
Comment 3 Benjamin Poulain 2013-04-05 18:04:39 PDT 
Created attachment 196711 [details]
Patch
Comment 4 Benjamin Poulain 2013-04-05 20:32:14 PDT 
Comment on attachment 196711 [details]
Patch

Clearing flags on attachment: 196711

Committed r147830: <http://trac.webkit.org/changeset/147830>
Comment 5 Benjamin Poulain 2013-04-05 20:32:18 PDT 
All reviewed patches have been landed.  Closing bug.