EOM
Created attachment 193433 [details] Patch
Created attachment 193434 [details] screenshot with overview grid and curtains
Looks like need to have overview grid on top of the chart and second grid on bottom. Otherwise it might confuse the web developer. I'll do that in the next patch.
Comment on attachment 193433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193433&action=review > Source/WebCore/inspector/front-end/FlameChart.js:442 > + this._overviewTimelineGrid.element.style.width = this._overviewContainer.clientHeight; width = height? > Source/WebCore/inspector/front-end/FlameChart.js:444 > + this._overviewTimelineGrid.showCurtains(this._overviewCalculator._gapOffset, this._overviewCalculator._gapWidth); Curtains should be removed from that component. They are for a different thing. You should add draggable window here. > Source/WebCore/inspector/front-end/flameChart.css:30 > + left: 0px; timeline-cpu style is private to timeline. it should load lazily with timeline panel so it won't apply here.
Created attachment 194064 [details] Patch
Created attachment 194065 [details] new screenshot
Created attachment 194069 [details] Patch
it is the first patch from the set. See meta bug: https://bugs.webkit.org/show_bug.cgi?id=112814
Comment on attachment 194069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194069&action=review > Source/WebCore/ChangeLog:13 > + Drive by change: fix the drag window & drag resizer mechancs for the case when parent element has zero offsetLeft. mechancs ? > Source/WebCore/inspector/front-end/FlameChart.js:62 > + this._canvas.onmousemove = this._onMouseMove.bind(this); Why not addEventListener?
Committed r146354: <http://trac.webkit.org/changeset/146354>