Bug 112489 - [WebKit2][GTK] Initialize gettext also in the UIProcess side
Summary: [WebKit2][GTK] Initialize gettext also in the UIProcess side
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 21:22 PDT by Gustavo Noronha (kov)
Modified: 2017-03-11 10:49 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2013-03-15 21:24 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-03-15 21:22:27 PDT 
[WebKit2][GTK] Initialize gettext also in the UIProcess side
Comment 1 Gustavo Noronha (kov) 2013-03-15 21:24:22 PDT 
Created attachment 193421 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-15 21:27:49 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-03-16 01:20:29 PDT 
Comment on attachment 193421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193421&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.cpp:56
> +static __attribute__((constructor)) void wkInitialize()

I guess we don't need to check whether constructor is supported by the compiler because we now require GCC >= 4.7 and Clang >= 3.0, right?
Comment 4 Gustavo Noronha (kov) 2013-03-17 07:21:20 PDT 
Right! I checked clang supports this gcc extension, too.
Comment 5 Andreas Kling 2014-02-05 11:20:36 PST 
Comment on attachment 193421 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Comment 6 Sergio Villar Senin 2014-02-06 00:12:47 PST 
I think this is still valid