plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
Created attachment 193398 [details] Patch
This one is slightly different from the original patch: in the pass different npp struct test, I first invoke waitUntilDone() and then load the plugin.
Comment on attachment 193398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193398&action=review > LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt:-1 > -This tests that a hidden plug-in gets a correct NPP_SetWindow the first time. I see, this output is from before the log message came back from the plugin, right?
Comment on attachment 193398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193398&action=review > LayoutTests/plugins/pass-different-npp-struct.html:5 > + if (window.testRunner) { > + testRunner.dumpAsText(); The mixing of 2 and 4 space indents is confusing, but I guess the old code was like that.
Comment on attachment 193398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193398&action=review >> LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt:-1 >> -This tests that a hidden plug-in gets a correct NPP_SetWindow the first time. > > I see, this output is from before the log message came back from the plugin, right? Right. wk2 also uses out-of-process plugins, and has the same problem as content shell
Comment on attachment 193398 [details] Patch Clearing flags on attachment: 193398 Committed r145967: <http://trac.webkit.org/changeset/145967>
All reviewed patches have been landed. Closing bug.