Bug 112474 - REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()
Summary: REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 15:57 PDT by Andy Estes
Modified: 2013-03-15 16:13 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2013-03-15 16:00 PDT, Andy Estes
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-03-15 15:57:43 PDT
REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()
Comment 1 Andy Estes 2013-03-15 16:00:39 PDT
Created attachment 193391 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-03-15 16:02:42 PDT
Comment on attachment 193391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193391&action=review

> Source/WebCore/platform/cf/SharedBufferCF.cpp:86
> +    RetainPtr<CFDataRef> cfData(AdoptCF, m_cfData.leakRef());

This should just assign.
Comment 3 Simon Fraser (smfr) 2013-03-15 16:08:21 PDT
Comment on attachment 193391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193391&action=review

>> Source/WebCore/platform/cf/SharedBufferCF.cpp:86
>> +    RetainPtr<CFDataRef> cfData(AdoptCF, m_cfData.leakRef());
> 
> This should just assign.

This is OK, after discussion.
Comment 4 Andy Estes 2013-03-15 16:13:44 PDT
Committed r145958: <http://trac.webkit.org/changeset/145958>