Bug 112472 - Text track cues do not update sizes when entering or exiting full screen.
Summary: Text track cues do not update sizes when entering or exiting full screen.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 15:52 PDT by Jer Noble
Modified: 2013-03-18 15:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.28 KB, patch)
2013-03-15 16:13 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (5.04 KB, patch)
2013-03-18 13:46 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-03-15 15:52:08 PDT
Text track cues do not update sizes when entering or exiting full screen.
Comment 1 Jer Noble 2013-03-15 16:13:02 PDT
Created attachment 193393 [details]
Patch
Comment 2 Build Bot 2013-03-15 17:50:04 PDT
Comment on attachment 193393 [details]
Patch

Attachment 193393 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17182237

New failing tests:
media/track/track-cue-mutable-text.html
Comment 3 WebKit Review Bot 2013-03-15 19:41:42 PDT
Comment on attachment 193393 [details]
Patch

Attachment 193393 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17186304

New failing tests:
media/track/track-cue-mutable-text.html
Comment 4 Build Bot 2013-03-15 23:27:11 PDT
Comment on attachment 193393 [details]
Patch

Attachment 193393 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17195207

New failing tests:
media/track/track-cue-mutable-text.html
Comment 5 Jer Noble 2013-03-18 13:46:05 PDT
Created attachment 193642 [details]
Patch

Fixed failing text track test.
Comment 6 Eric Carlson 2013-03-18 14:13:23 PDT
Comment on attachment 193642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193642&action=review

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:140
> +    if (!hasDisplayTree ())

Nit: extra space before "()".
Comment 7 Jer Noble 2013-03-18 14:14:51 PDT
<rdar://problem/13340889>
Comment 8 Jer Noble 2013-03-18 15:53:49 PDT
Committed r146140: <http://trac.webkit.org/changeset/146140>