Bug 112469 - Reduce amount of platform specific code in MessagePortChannel
Summary: Reduce amount of platform specific code in MessagePortChannel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 14:58 PDT by Alexey Proskuryakov
Modified: 2013-03-15 16:42 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (14.47 KB, patch)
2013-03-15 15:02 PDT, Alexey Proskuryakov
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
proposed patch (14.62 KB, patch)
2013-03-15 15:50 PDT, Alexey Proskuryakov
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-03-15 14:58:40 PDT
MessagePortChannel and PlatformMessagePortChannel classes are both implemented in forked files. MessagePortChannel doesn't have any logic of its own, so there is no reason to complicate the code by having these separate.

This patch reduces the amount of calling through layers, making PlatformMessagePortChannel more of a data object, akin to ResourceHandleData.
Comment 1 Alexey Proskuryakov 2013-03-15 15:02:07 PDT
Created attachment 193377 [details]
proposed patch
Comment 2 WebKit Review Bot 2013-03-15 15:17:19 PDT
Comment on attachment 193377 [details]
proposed patch

Attachment 193377 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17118287
Comment 3 WebKit Review Bot 2013-03-15 15:24:26 PDT
Comment on attachment 193377 [details]
proposed patch

Attachment 193377 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17145314
Comment 4 Peter Beverloo (cr-android ews) 2013-03-15 15:42:59 PDT
Comment on attachment 193377 [details]
proposed patch

Attachment 193377 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17222123
Comment 5 Alexey Proskuryakov 2013-03-15 15:50:02 PDT
Created attachment 193387 [details]
proposed patch

Ok, ok.
Comment 6 Alexey Proskuryakov 2013-03-15 16:42:57 PDT
Committed <http://trac.webkit.org/changeset/145965>.