WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112469
Reduce amount of platform specific code in MessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=112469
Summary
Reduce amount of platform specific code in MessagePortChannel
Alexey Proskuryakov
Reported
2013-03-15 14:58:40 PDT
MessagePortChannel and PlatformMessagePortChannel classes are both implemented in forked files. MessagePortChannel doesn't have any logic of its own, so there is no reason to complicate the code by having these separate. This patch reduces the amount of calling through layers, making PlatformMessagePortChannel more of a data object, akin to ResourceHandleData.
Attachments
proposed patch
(14.47 KB, patch)
2013-03-15 15:02 PDT
,
Alexey Proskuryakov
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
proposed patch
(14.62 KB, patch)
2013-03-15 15:50 PDT
,
Alexey Proskuryakov
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-03-15 15:02:07 PDT
Created
attachment 193377
[details]
proposed patch
WebKit Review Bot
Comment 2
2013-03-15 15:17:19 PDT
Comment on
attachment 193377
[details]
proposed patch
Attachment 193377
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://webkit-commit-queue.appspot.com/results/17118287
WebKit Review Bot
Comment 3
2013-03-15 15:24:26 PDT
Comment on
attachment 193377
[details]
proposed patch
Attachment 193377
[details]
did not pass cr-linux-debug-ews (chromium-xvfb): Output:
http://webkit-commit-queue.appspot.com/results/17145314
Peter Beverloo (cr-android ews)
Comment 4
2013-03-15 15:42:59 PDT
Comment on
attachment 193377
[details]
proposed patch
Attachment 193377
[details]
did not pass cr-android-ews (chromium-android): Output:
http://webkit-commit-queue.appspot.com/results/17222123
Alexey Proskuryakov
Comment 5
2013-03-15 15:50:02 PDT
Created
attachment 193387
[details]
proposed patch Ok, ok.
Alexey Proskuryakov
Comment 6
2013-03-15 16:42:57 PDT
Committed <
http://trac.webkit.org/changeset/145965
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug