112458 – Roll out r145838

RESOLVED FIXED 112458

Roll out r145838

https://bugs.webkit.org/show_bug.cgi?id=112458

Summary Roll out r145838

Mark Hahnenberg

Reported 2013-03-15 12:57:46 PDT

Requested by Filip Pizlo.

Attachments
Patch (35.83 KB, patch) 2013-03-15 13:03 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (35.91 KB, patch) 2013-03-15 13:10 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (35.93 KB, patch) 2013-03-15 13:22 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2013-03-15 13:03:30 PDT

Created attachment 193357 [details] Patch

WebKit Review Bot

Comment 2 2013-03-15 13:06:04 PDT

Attachment 193357 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/script-tests/string-lookup-hit-identifier.js', u'LayoutTests/fast/js/regress/script-tests/string-lookup-hit.js', u'LayoutTests/fast/js/regress/script-tests/string-lookup-miss.js', u'LayoutTests/fast/js/regress/string-lookup-hit-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-hit-identifier-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-hit-identifier.html', u'LayoutTests/fast/js/regress/string-lookup-hit.html', u'LayoutTests/fast/js/regress/string-lookup-miss-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-miss.html', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/DerivedSources.make', u'Source/JavaScriptCore/DerivedSources.pri', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/interpreter/CallFrame.h', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/runtime/CommonIdentifiers.h', u'Source/JavaScriptCore/runtime/JSCell.cpp', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSCellInlines.h', u'Source/JavaScriptCore/runtime/JSGlobalData.cpp', u'Source/JavaScriptCore/runtime/JSGlobalData.h', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/Lookup.cpp', u'Source/JavaScriptCore/runtime/ObjectPrototype.cpp', u'Source/JavaScriptCore/runtime/ObjectPrototype.h', u'Source/JavaScriptCore/runtime/PropertyMapHashTable.h', u'Source/JavaScriptCore/runtime/Structure.h', u'Source/JavaScriptCore/runtime/StructureInlines.h']" exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.cpp:427: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/JavaScriptCore/runtime/ObjectPrototype.cpp:44: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Hahnenberg

Comment 3 2013-03-15 13:10:21 PDT

Created attachment 193360 [details] Patch

WebKit Review Bot

Comment 4 2013-03-15 13:14:17 PDT

Attachment 193360 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/script-tests/string-lookup-hit-identifier.js', u'LayoutTests/fast/js/regress/script-tests/string-lookup-hit.js', u'LayoutTests/fast/js/regress/script-tests/string-lookup-miss.js', u'LayoutTests/fast/js/regress/string-lookup-hit-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-hit-identifier-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-hit-identifier.html', u'LayoutTests/fast/js/regress/string-lookup-hit.html', u'LayoutTests/fast/js/regress/string-lookup-miss-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-miss.html', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/DerivedSources.make', u'Source/JavaScriptCore/DerivedSources.pri', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/interpreter/CallFrame.h', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/runtime/CommonIdentifiers.h', u'Source/JavaScriptCore/runtime/JSCell.cpp', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSCellInlines.h', u'Source/JavaScriptCore/runtime/JSGlobalData.cpp', u'Source/JavaScriptCore/runtime/JSGlobalData.h', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/Lookup.cpp', u'Source/JavaScriptCore/runtime/ObjectPrototype.cpp', u'Source/JavaScriptCore/runtime/ObjectPrototype.h', u'Source/JavaScriptCore/runtime/PropertyMapHashTable.h', u'Source/JavaScriptCore/runtime/Structure.h', u'Source/JavaScriptCore/runtime/StructureInlines.h']" exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.cpp:427: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/JavaScriptCore/runtime/ObjectPrototype.cpp:44: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 5 2013-03-15 13:20:35 PDT

Comment on attachment 193360 [details] Patch Rejecting attachment 193360 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 193360, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/17191182

Mark Hahnenberg

Comment 6 2013-03-15 13:22:47 PDT

Created attachment 193365 [details] Patch

WebKit Review Bot

Comment 7 2013-03-15 13:24:42 PDT

Attachment 193365 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/script-tests/string-lookup-hit-identifier.js', u'LayoutTests/fast/js/regress/script-tests/string-lookup-hit.js', u'LayoutTests/fast/js/regress/script-tests/string-lookup-miss.js', u'LayoutTests/fast/js/regress/string-lookup-hit-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-hit-identifier-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-hit-identifier.html', u'LayoutTests/fast/js/regress/string-lookup-hit.html', u'LayoutTests/fast/js/regress/string-lookup-miss-expected.txt', u'LayoutTests/fast/js/regress/string-lookup-miss.html', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/DerivedSources.make', u'Source/JavaScriptCore/DerivedSources.pri', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/interpreter/CallFrame.h', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/runtime/CommonIdentifiers.h', u'Source/JavaScriptCore/runtime/JSCell.cpp', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSCellInlines.h', u'Source/JavaScriptCore/runtime/JSGlobalData.cpp', u'Source/JavaScriptCore/runtime/JSGlobalData.h', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/Lookup.cpp', u'Source/JavaScriptCore/runtime/ObjectPrototype.cpp', u'Source/JavaScriptCore/runtime/ObjectPrototype.h', u'Source/JavaScriptCore/runtime/PropertyMapHashTable.h', u'Source/JavaScriptCore/runtime/Structure.h', u'Source/JavaScriptCore/runtime/StructureInlines.h']" exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.cpp:427: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/JavaScriptCore/runtime/ObjectPrototype.cpp:44: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 8 2013-03-15 14:54:53 PDT

Comment on attachment 193365 [details] Patch Clearing flags on attachment: 193365 Committed r145945: <http://trac.webkit.org/changeset/145945>

WebKit Review Bot

Comment 9 2013-03-15 14:54:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component JavaScriptCore

Assignee

Mark Hahnenberg

Reported

2013-03-15 12:57 PDT

Modified

2013-03-15 14:54 PDT History

CC List

3 users Show

URL

Keywords

Depends on

Blocks

112233

Dependencies

tree graph