When the style checker ran on this patch https://bugs.webkit.org/attachment.cgi?id=193319&action=review it passed both locally with webkit-patch and remotely on EWS's style checker.
(In reply to comment #0) > When the style checker ran on this patch https://bugs.webkit.org/attachment.cgi?id=193319&action=review it passed both locally with webkit-patch and remotely on EWS's style checker. This patch has "No new tests (OOPS!)." so I would expect it to fail style.
Created attachment 218043 [details] patch I just correct the regular expression for "No new tests (OOPS!)."
Comment on attachment 218043 [details] patch Please update its unittest and the comment above too.
Created attachment 218054 [details] patch fix
Comment on attachment 218054 [details] patch fix Rejecting attachment 218054 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 218054, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/39318135
Comment on attachment 218054 [details] patch fix View in context: https://bugs.webkit.org/attachment.cgi?id=218054&action=review > Tools/ChangeLog:10 > + simple regex fix to check "No new tests (OOPS!)." Hehe, this comment killed the CQ. :)
Created attachment 218056 [details] patch fix HOPPA! == OOPS!
Comment on attachment 218056 [details] patch fix View in context: https://bugs.webkit.org/attachment.cgi?id=218056&action=review > Tools/ChangeLog:10 > + simple regex fix to check "No new tests (HOPPA!)." We shouldn't write "hoppá", otherwise LGTM.
Landed in http://trac.webkit.org/changeset/159997