Bug 112448 - [BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
Summary: [BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-03-15 08:16 PDT by Alberto Garcia
Modified: 2013-03-21 12:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2013-03-15 08:18 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Patch (1.25 KB, patch)
2013-03-21 12:31 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-15 08:16:44 PDT 
This changed in r121381 (see bug 89123).
Comment 1 Alberto Garcia 2013-03-15 08:18:03 PDT 
Created attachment 193313 [details]
Patch
Comment 2 Xan Lopez 2013-03-21 11:54:13 PDT 
Comment on attachment 193313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193313&action=review

> Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:35
> +    JSC::JSLockHolder lock(m_globalData);

Seems weird that JSLock didn't need the explicit namespace but JSLockHolder does. Other than that seems sensible given the patch in the other bug.
Comment 3 Alberto Garcia 2013-03-21 12:31:23 PDT 
Created attachment 194316 [details]
Patch

Right, here's the updated patch.
Comment 4 Xan Lopez 2013-03-21 12:53:00 PDT 
Comment on attachment 194316 [details]
Patch

Bam.
Comment 5 WebKit Review Bot 2013-03-21 12:57:50 PDT 
Comment on attachment 194316 [details]
Patch

Clearing flags on attachment: 194316

Committed r146502: <http://trac.webkit.org/changeset/146502>
Comment 6 WebKit Review Bot 2013-03-21 12:57:53 PDT 
All reviewed patches have been landed.  Closing bug.