Bug 112445 – Support connecting the Web Inspector without showing it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Timothy Hatcher]

We should support connecting the Web Inspector without showing the window or attaching. This would allow you to get the debugger attached in the background. When a breakpoint is hit the Inspector will open. You should also be able hide the Inspector and keep it connected.

These options will not the be default behavior, but an option in menus.

[Timothy Hatcher]

Created attachment 193307 [details]
Proposed Change

[Radar WebKit Bug Importer]

<rdar://problem/13430045>

[Timothy Hatcher]

Created attachment 193314 [details]
Proposed Change (Take 2)

[Joseph Pecoraro]

Comment on attachment 193314 [details]
Proposed Change (Take 2)

Looks good to me.

[Timothy Hatcher]

Anders, Sam, want to do a quick review of this?

[Timothy Hatcher]

Created attachment 193437 [details]
Proposed Change (Take 3)

I've simplified some things since the last patch.

[Early Warning System Bot]

Comment on attachment 193437 [details]
Proposed Change (Take 3)

Attachment 193437 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17188423

[EFL EWS Bot]

Comment on attachment 193437 [details]
Proposed Change (Take 3)

Attachment 193437 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17222202

[Sam Weinig]

Comment on attachment 193437 [details]
Proposed Change (Take 3)

View in context: https://bugs.webkit.org/attachment.cgi?id=193437&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:413
> +        WKView *inspectedView = m_page->wkView();

Please don't access the WKView directly here (that function should be removed).  Instead, this should go through the PageClient.

[Timothy Hatcher]

Comment on attachment 193437 [details]
Proposed Change (Take 3)

View in context: https://bugs.webkit.org/attachment.cgi?id=193437&action=review

>> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:413
>> +        WKView *inspectedView = m_page->wkView();
> 
> Please don't access the WKView directly here (that function should be removed).  Instead, this should go through the PageClient.

This isn't new to this patch, we use wkView in a couple other places in this file. PageClient isn't exposed on WebPageProxy right now. I'd like to keep this patch as-is. I filed bug 112829 to track that.

[Timothy Hatcher]

Created attachment 194102 [details]
Proposed Change (Take 4)

[Early Warning System Bot]

Comment on attachment 194102 [details]
Proposed Change (Take 4)

Attachment 194102 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17258038

[Timothy Hatcher]

Created attachment 194108 [details]
Proposed Change (Take 5)

[Early Warning System Bot]

Comment on attachment 194108 [details]
Proposed Change (Take 5)

Attachment 194108 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17253236

[Timothy Hatcher]

Created attachment 194122 [details]
Proposed Change (Take 6)

[Timothy Hatcher]

Sam or Anders, mind taking a look at take 6?

[WebKit Review Bot]

Comment on attachment 194122 [details]
Proposed Change (Take 6)

Clearing flags on attachment: 194122

Committed r146518: <http://trac.webkit.org/changeset/146518>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

This patch appears to have broken two tests on ML Debug testers:
e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r146520%20(8040)/results.html

[Ryosuke Niwa]

This patch may have caused inspector/profiler/cpu-profiler-profile-removal.html to intermittently crash. See:
https://bugs.webkit.org/show_bug.cgi?id=113020

[Timothy Hatcher]

These are ASSERTs. I am looking into it.