Bug 112440 - Web Inspector: Allow toolbar customization
Summary: Web Inspector: Allow toolbar customization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexei Filippov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 06:22 PDT by Alexei Filippov
Modified: 2013-03-20 03:03 PDT (History)
9 users (show)

See Also:

Attachments
Patch (12.37 KB, patch)
2013-03-15 06:44 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
screenshot (11.77 KB, image/png)
2013-03-15 10:24 PDT, Alexei Filippov 		no flags Details
Patch (11.01 KB, patch)
2013-03-15 11:01 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2013-03-15 06:22:59 PDT 
Add a tools menu item that allows the user to show/hide
inspector panels on the toolbar.
Comment 1 Alexei Filippov 2013-03-15 06:44:57 PDT 
Created attachment 193299 [details]
Patch
Comment 2 Yury Semikhatsky 2013-03-15 09:14:52 PDT 
Screenshot?
Comment 3 Yury Semikhatsky 2013-03-15 09:29:33 PDT 
Comment on attachment 193299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193299&action=review

> Source/WebCore/inspector/front-end/Toolbar.js:131
> +            count += this._isPanelVisible(this._panelDescriptors[i].name()) ? 1 : 0;

if (this._isPanelVisible(this._panelDescriptors[i].name()))
    ++count;

> Source/WebCore/inspector/front-end/Toolbar.js:153
> +        var index = this._panelDescriptors.indexOf(panelDescriptor);

var index = ... + 1

> Source/WebCore/inspector/front-end/inspector.css:286
> +    font-weight: bold;

Consider sharing common properties with #toolbar-dropdown-arrow

> Source/WebCore/inspector/front-end/inspector.js:48
> +        var allDescriptors = [elements, console, network, scripts, timeline, profiles, audits, resources];

Do it in a separate change please.
Comment 4 Alexei Filippov 2013-03-15 10:24:07 PDT 
Created attachment 193330 [details]
screenshot
Comment 5 Alexei Filippov 2013-03-15 11:01:10 PDT 
Created attachment 193339 [details]
Patch
Comment 6 Alexei Filippov 2013-03-15 11:05:33 PDT 
Comment on attachment 193299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193299&action=review

>> Source/WebCore/inspector/front-end/Toolbar.js:131
>> +            count += this._isPanelVisible(this._panelDescriptors[i].name()) ? 1 : 0;
> 
> if (this._isPanelVisible(this._panelDescriptors[i].name()))
>     ++count;

ok

>> Source/WebCore/inspector/front-end/Toolbar.js:153
>> +        var index = this._panelDescriptors.indexOf(panelDescriptor);
> 
> var index = ... + 1

rewrote this part

>> Source/WebCore/inspector/front-end/inspector.css:286
>> +    font-weight: bold;
> 
> Consider sharing common properties with #toolbar-dropdown-arrow

I'll think about it.

>> Source/WebCore/inspector/front-end/inspector.js:48
>> +        var allDescriptors = [elements, console, network, scripts, timeline, profiles, audits, resources];
> 
> Do it in a separate change please.

sure.
Comment 7 WebKit Review Bot 2013-03-20 03:03:30 PDT 
Comment on attachment 193339 [details]
Patch

Clearing flags on attachment: 193339

Committed r146319: <http://trac.webkit.org/changeset/146319>
Comment 8 WebKit Review Bot 2013-03-20 03:03:34 PDT 
All reviewed patches have been landed.  Closing bug.