Bug 112424 - [BlackBerry] Detach overlays from page when compositor is detached
Summary: [BlackBerry] Detach overlays from page when compositor is detached
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 03:08 PDT by Arvid Nilsson
Modified: 2013-03-18 06:07 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.51 KB, patch)
2013-03-18 05:27 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2013-03-15 03:08:57 PDT 
Otherwise the overlays will have a dangling pointer to the WebPage.

We don't bother with webkit-thread overlays, since they are obsolete (and only used internally in WebKit, so they go down together with the WebPage anyway).

PR 309160
Comment 1 Arvid Nilsson 2013-03-18 05:27:07 PDT 
Created attachment 193542 [details]
Patch
Comment 2 Rob Buis 2013-03-18 05:32:26 PDT 
Comment on attachment 193542 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-03-18 06:07:38 PDT 
Comment on attachment 193542 [details]
Patch

Clearing flags on attachment: 193542

Committed r146058: <http://trac.webkit.org/changeset/146058>
Comment 4 WebKit Review Bot 2013-03-18 06:07:42 PDT 
All reviewed patches have been landed.  Closing bug.