Bug 112423 - Web Inspector: Flame Chart. xOffset calculates incorrectly when chart width less that canvas.width
Summary: Web Inspector: Flame Chart. xOffset calculates incorrectly when chart width l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 03:08 PDT by Ilya Tikhonovsky
Modified: 2013-03-15 03:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.34 KB, patch)
2013-03-15 03:20 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-03-15 03:08:41 PDT 
There were many places when we have to check the edge cases for xOffset.
I've externalized the mechanics.

patch to follow.
Comment 1 Ilya Tikhonovsky 2013-03-15 03:20:06 PDT 
Created attachment 193271 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-03-15 03:48:33 PDT 
Committed r145894: <http://trac.webkit.org/changeset/145894>