Bug 112420 - Call release() when a RefPtr is returned.
Summary: Call release() when a RefPtr is returned.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-15 02:18 PDT by Jaehun Lim
Modified: 2013-03-15 03:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2013-03-15 02:31 PDT, Jaehun Lim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2013-03-15 02:18:59 PDT 
release() should be called on a RefPtr to convert it to a PassRefPtr.
Comment 1 Jaehun Lim 2013-03-15 02:31:00 PDT 
Created attachment 193262 [details]
Patch
Comment 2 Alan Cutter 2013-03-15 02:43:21 PDT 
I believe this happens implicitly: http://trac.webkit.org/browser/trunk/Source/WTF/wtf/PassRefPtr.h#L96
Comment 3 Eric Seidel (no email) 2013-03-15 03:18:15 PDT 
Comment on attachment 193262 [details]
Patch

Looks right.
Comment 4 WebKit Review Bot 2013-03-15 03:24:47 PDT 
Comment on attachment 193262 [details]
Patch

Clearing flags on attachment: 193262

Committed r145892: <http://trac.webkit.org/changeset/145892>
Comment 5 WebKit Review Bot 2013-03-15 03:24:51 PDT 
All reviewed patches have been landed.  Closing bug.