WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112420
Call release() when a RefPtr is returned.
https://bugs.webkit.org/show_bug.cgi?id=112420
Summary
Call release() when a RefPtr is returned.
Jaehun Lim
Reported
2013-03-15 02:18:59 PDT
release() should be called on a RefPtr to convert it to a PassRefPtr.
Attachments
Patch
(1.56 KB, patch)
2013-03-15 02:31 PDT
,
Jaehun Lim
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jaehun Lim
Comment 1
2013-03-15 02:31:00 PDT
Created
attachment 193262
[details]
Patch
Alan Cutter
Comment 2
2013-03-15 02:43:21 PDT
I believe this happens implicitly:
http://trac.webkit.org/browser/trunk/Source/WTF/wtf/PassRefPtr.h#L96
Eric Seidel (no email)
Comment 3
2013-03-15 03:18:15 PDT
Comment on
attachment 193262
[details]
Patch Looks right.
WebKit Review Bot
Comment 4
2013-03-15 03:24:47 PDT
Comment on
attachment 193262
[details]
Patch Clearing flags on attachment: 193262 Committed
r145892
: <
http://trac.webkit.org/changeset/145892
>
WebKit Review Bot
Comment 5
2013-03-15 03:24:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug