Bug 112412 - Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
Summary: Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-14 23:48 PDT by Eugene Klyuchnikov
Modified: 2013-03-15 11:49 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.24 KB, patch)
2013-03-15 00:05 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (6.99 KB, patch)
2013-03-15 03:05 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (7.01 KB, patch)
2013-03-15 04:29 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-03-14 23:48:47 PDT 
Return types for some members are confusing (Object).
Comment 1 Eugene Klyuchnikov 2013-03-15 00:05:17 PDT 
Created attachment 193244 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-03-15 01:12:59 PDT 
Comment on attachment 193244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193244&action=review

> Source/WebCore/inspector/front-end/NetworkRequest.js:79
> +/** @typedef {!NetworkAgent.WebSocketFrame|{errorMessage: string, time: number}} */

This is not a valid type, we don't use | other than for undefined.
Comment 3 Eugene Klyuchnikov 2013-03-15 03:05:39 PDT 
Created attachment 193268 [details]
Patch
Comment 4 Eugene Klyuchnikov 2013-03-15 03:07:11 PDT 
Comment on attachment 193244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193244&action=review

>> Source/WebCore/inspector/front-end/NetworkRequest.js:79
>> +/** @typedef {!NetworkAgent.WebSocketFrame|{errorMessage: string, time: number}} */
> 
> This is not a valid type, we don't use | other than for undefined.

Fixed. Thanks.
Comment 5 Mike West 2013-03-15 04:09:34 PDT 
Comment on attachment 193268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193268&action=review

> Source/WebCore/inspector/front-end/NetworkRequest.js:615
> +        this._sortedResponseHeaders.sort(function(a, b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()) });

Nit: Since you're cleaning up style here anyway, please add a ';' after the return statement in the function body.
Comment 6 Eugene Klyuchnikov 2013-03-15 04:29:58 PDT 
Created attachment 193278 [details]
Patch
Comment 7 Eugene Klyuchnikov 2013-03-15 04:30:24 PDT 
Comment on attachment 193268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193268&action=review

>> Source/WebCore/inspector/front-end/NetworkRequest.js:615
>> +        this._sortedResponseHeaders.sort(function(a, b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()) });
> 
> Nit: Since you're cleaning up style here anyway, please add a ';' after the return statement in the function body.

Done.
Comment 8 WebKit Review Bot 2013-03-15 11:49:34 PDT 
Comment on attachment 193278 [details]
Patch

Clearing flags on attachment: 193278

Committed r145926: <http://trac.webkit.org/changeset/145926>
Comment 9 WebKit Review Bot 2013-03-15 11:49:37 PDT 
All reviewed patches have been landed.  Closing bug.