RESOLVED FIXED 112412
Web Inspector: [Network] Refine JSDocs in NetworkRequest.js 
https://bugs.webkit.org/show_bug.cgi?id=112412
Summary Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
Eugene Klyuchnikov
Reported 2013-03-14 23:48:47 PDT
Return types for some members are confusing (Object).
Attachments
Patch (7.24 KB, patch)
2013-03-15 00:05 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (6.99 KB, patch)
2013-03-15 03:05 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (7.01 KB, patch)
2013-03-15 04:29 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-15 00:05:17 PDT
Created attachment 193244 [details] Patch
Vsevolod Vlasov
Comment 2 2013-03-15 01:12:59 PDT
Comment on attachment 193244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193244&action=review > Source/WebCore/inspector/front-end/NetworkRequest.js:79 > +/** @typedef {!NetworkAgent.WebSocketFrame|{errorMessage: string, time: number}} */ This is not a valid type, we don't use | other than for undefined.
Eugene Klyuchnikov
Comment 3 2013-03-15 03:05:39 PDT
Created attachment 193268 [details] Patch
Eugene Klyuchnikov
Comment 4 2013-03-15 03:07:11 PDT
Comment on attachment 193244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193244&action=review >> Source/WebCore/inspector/front-end/NetworkRequest.js:79 >> +/** @typedef {!NetworkAgent.WebSocketFrame|{errorMessage: string, time: number}} */ > > This is not a valid type, we don't use | other than for undefined. Fixed. Thanks.
Mike West
Comment 5 2013-03-15 04:09:34 PDT
Comment on attachment 193268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193268&action=review > Source/WebCore/inspector/front-end/NetworkRequest.js:615 > + this._sortedResponseHeaders.sort(function(a, b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()) }); Nit: Since you're cleaning up style here anyway, please add a ';' after the return statement in the function body.
Eugene Klyuchnikov
Comment 6 2013-03-15 04:29:58 PDT
Created attachment 193278 [details] Patch
Eugene Klyuchnikov
Comment 7 2013-03-15 04:30:24 PDT
Comment on attachment 193268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193268&action=review >> Source/WebCore/inspector/front-end/NetworkRequest.js:615 >> + this._sortedResponseHeaders.sort(function(a, b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()) }); > > Nit: Since you're cleaning up style here anyway, please add a ';' after the return statement in the function body. Done.
WebKit Review Bot
Comment 8 2013-03-15 11:49:34 PDT
Comment on attachment 193278 [details] Patch Clearing flags on attachment: 193278 Committed r145926: <http://trac.webkit.org/changeset/145926>
WebKit Review Bot
Comment 9 2013-03-15 11:49:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.