Bug 112404 – Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Sankeerth V S]

While deleting the entries of the data grid by clicking on 'Delete' status bar button, deletion of selected node should trigger selection of
next possible (backward/forward) DataGridNode.

[Sankeerth V S]

Created attachment 193272 [details]
Patch

[WebKit Review Bot]

Comment on attachment 193272 [details]
Patch

Clearing flags on attachment: 193272

Committed r145901: <http://trac.webkit.org/changeset/145901>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Vivek Galatage]

In my opinion, node selection change should happen inherently within the DataGrid whenever a node is removed. Making an explicit call to changeNodeAfterDeletion() from the call site (e.g. _deleteButtonClicked) shouldn't be necessary. 

Also when the DataGrid is used in multiple views with the inline deleting option, and if the call site doesn't invoke changeNodeAfterDeletion() explicitly, the DataGrid behavior would be inconsistent with respect to other views and this would hamper the User experience.

I would recommend that this method changeNodeAfterDeletion() be moved in the DataGridNode and make it a private API with more meaningful naming such as ( _nodeSelectionChanged() ) and should be invoked from WebInspector.DataGridNode.removeChild() implicitly.

@vsevik, I would be glad to have your views on the above comment.

[Vsevolod Vlasov]

(In reply to comment #4)
> In my opinion, node selection change should happen inherently within the DataGrid whenever a node is removed. Making an explicit call to changeNodeAfterDeletion() from the call site (e.g. _deleteButtonClicked) shouldn't be necessary. 
> 
> Also when the DataGrid is used in multiple views with the inline deleting option, and if the call site doesn't invoke changeNodeAfterDeletion() explicitly, the DataGrid behavior would be inconsistent with respect to other views and this would hamper the User experience.
> 
> I would recommend that this method changeNodeAfterDeletion() be moved in the DataGridNode and make it a private API with more meaningful naming such as ( _nodeSelectionChanged() ) and should be invoked from WebInspector.DataGridNode.removeChild() implicitly.
> 
> @vsevik, I would be glad to have your views on the above comment.

Sounds resanobale, would you be willing to file a new bug a implement this?

[Sankeerth V S]

(In reply to comment #4)
> In my opinion, node selection change should happen inherently within the DataGrid whenever a node is removed. Making an explicit call to changeNodeAfterDeletion() from the call site (e.g. _deleteButtonClicked) shouldn't be necessary. 
> 
> Also when the DataGrid is used in multiple views with the inline deleting option, and if the call site doesn't invoke changeNodeAfterDeletion() explicitly, the DataGrid behavior would be inconsistent with respect to other views and this would hamper the User experience.
> 
> I would recommend that this method changeNodeAfterDeletion() be moved in the DataGridNode and make it a private API with more meaningful naming such as ( _nodeSelectionChanged() ) and should be invoked from WebInspector.DataGridNode.removeChild() implicitly.
> 
> @vsevik, I would be glad to have your views on the above comment.

Thank you for your valuable suggestions. What you mentioned is is right. I hadn't thought about it before. I shall incorporate the changes you have mentioned.

[Sankeerth V S]

> Sounds reasonable, would you be willing to file a new bug a implement this?

Sure. I shall open a new bug and implement the above mentioned changes.
Thank you.