Original issue: https://code.google.com/p/chromium/issues/detail?id=195100 Dev Tools -- Resources -- Unable to delete newly added keys under Local Storage. Recent changes removed forced "refresh" on editing. So duplicate keys do not combine with existing ones in UI.
Qualification: in case value is changed - all goes well. But in case value is not changed (it was already empty) - we receive no notification -> dupe is not removed.
Created attachment 193265 [details] Patch
Created attachment 193521 [details] Patch less-invasive-patch
Comment on attachment 193521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193521&action=review > Source/WebCore/ChangeLog:8 > + Avoid duplicates in case value is not updated (consequently, Please give a more detailed description of what's wrong and how this patch fixes the bug (the issue summary is not helpful either.) > Source/WebCore/inspector/front-end/DOMStorageItemsView.js:250 > + masterNode.select(); Either this line should follow the method call or the method should be named, _removeDupesAndSelect.
Comment on attachment 193521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193521&action=review >> Source/WebCore/ChangeLog:8 >> + Avoid duplicates in case value is not updated (consequently, > > Please give a more detailed description of what's wrong and how this patch fixes the bug (the issue summary is not helpful either.) Done. >> Source/WebCore/inspector/front-end/DOMStorageItemsView.js:250 >> + masterNode.select(); > > Either this line should follow the method call or the method should be named, _removeDupesAndSelect. Addressed.
Created attachment 193539 [details] Patch
Comment on attachment 193539 [details] Patch Clearing flags on attachment: 193539 Committed r146057: <http://trac.webkit.org/changeset/146057>
All reviewed patches have been landed. Closing bug.