[Chromium] Focus Plugin on TouchStart

[Fady Samuel]

[Chromium] Focus Plugin on TouchStart

[Fady Samuel]

Created attachment 193193 [details]
Patch

[Sadrul Habib Chowdhury]

Since we do this for mouse-down events, I think it makes sense to do this on touch-press events too. LGTM

[Adam Barth]

Comment on attachment 193193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193193&action=review

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:779
> +            Frame* containingFrame = static_cast<FrameView*>(parent())->frame();
> +            if (Page* currentPage = containingFrame->page())
> +                currentPage->focusController()->setFocusedNode(m_element, containingFrame);
> +            else
> +                containingFrame->document()->setFocusedNode(m_element);

This seems copy/pasted from WebPluginContainerImpl::handleMouseEvent.  Can we create a small helper function rather than copy/pasting code?

[Fady Samuel]

Created attachment 193366 [details]
Patch

[WebKit Review Bot]

Comment on attachment 193366 [details]
Patch

Clearing flags on attachment: 193366

Committed r145957: <http://trac.webkit.org/changeset/145957>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.