Bug 112384 - [chromium] Small pixel differences in scroll bars after r145844
Summary: [chromium] Small pixel differences in scroll bars after r145844
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Flack
URL:
Keywords:
Depends on: 102580
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-14 14:58 PDT by Kenneth Russell
Modified: 2013-03-18 18:09 PDT (History)
1 user (show)

See Also:


Attachments
Patch (313.77 KB, patch)
2013-03-18 08:50 PDT, Robert Flack
no flags Details | Formatted Diff | Diff
Patch (314.87 KB, patch)
2013-03-18 08:54 PDT, Robert Flack
no flags Details | Formatted Diff | Diff
Patch (321.38 KB, patch)
2013-03-18 17:33 PDT, Robert Flack
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2013-03-14 14:58:11 PDT
The following layout tests have small pixel differences in their rendering on Win7, apparently after http://trac.webkit.org/changeset/145844 :

fast/forms/basic-textareas-quirks.html
fast/forms/basic-textareas.html
fast/overflow/overflow-x-y.html
fast/parser/open-comment-in-textarea.html
fast/replaced/width100percent-textarea.html

Looking at the differences it isn't 100% clear to me that the new behavior is desired; the scroll bar and top arrow look slightly worse to me. Assigning this bug to flackr to take a look.

To see the differences, run

webkit-patch garden-o-matic

and look for these tests. I may try to suppress these failures in the meantime, so you may need to look under the "expected failures" tab for them.
Comment 1 Robert Flack 2013-03-15 11:07:44 PDT
The difference in the arrow is very strange. As for the track I did expect the difference but I can see that not drawing a 1px track between scroll bar buttons may be preferred. Looking into this.
Comment 2 Robert Flack 2013-03-18 08:50:27 PDT
Created attachment 193573 [details]
Patch
Comment 3 Robert Flack 2013-03-18 08:54:51 PDT
Created attachment 193574 [details]
Patch
Comment 4 Kenneth Russell 2013-03-18 11:42:47 PDT
Comment on attachment 193574 [details]
Patch

Thanks for the update. Seems fine. r=me
Comment 5 Robert Flack 2013-03-18 17:33:09 PDT
Created attachment 193703 [details]
Patch
Comment 6 Robert Flack 2013-03-18 17:41:04 PDT
Comment on attachment 193703 [details]
Patch

Hey, I just rebaselined the one test that will need it. Thanks for reviewing.
Comment 7 Kenneth Russell 2013-03-18 17:46:20 PDT
Comment on attachment 193703 [details]
Patch

LGTM
Comment 8 WebKit Review Bot 2013-03-18 18:09:52 PDT
Comment on attachment 193703 [details]
Patch

Clearing flags on attachment: 193703

Committed r146167: <http://trac.webkit.org/changeset/146167>
Comment 9 WebKit Review Bot 2013-03-18 18:09:55 PDT
All reviewed patches have been landed.  Closing bug.