Bug 112365 - [BlackBerry] Enable USE_SYSTEM_MALLOC by default
Summary: [BlackBerry] Enable USE_SYSTEM_MALLOC by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-03-14 10:50 PDT by Alberto Garcia
Modified: 2013-03-19 10:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2013-03-14 10:52 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Patch (2.43 KB, patch)
2013-03-18 10:44 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-14 10:50:07 PDT 
I'm getting lots of these otherwise:

In file included from /home/berto/devel/code/webkit/Source/WTF/config.h:30:0,
                 from /home/berto/devel/code/webkit/Source/WTF/wtf/HashTable.cpp:20:
/home/berto/devel/code/webkit/Source/WTF/wtf/Platform.h:501:0: warning: "USE_SYSTEM_MALLOC" redefined [enabled by default]
/home/berto/devel/code/webkit/WebKitBuild/armle-v7/Release/cmakeconfig.h:131:0: note: this is the location of the previous definition
Comment 1 Alberto Garcia 2013-03-14 10:52:23 PDT 
Created attachment 193150 [details]
Patch
Comment 2 Alberto Garcia 2013-03-18 10:44:43 PDT 
Created attachment 193600 [details]
Patch

Since there's the build option to enable/disable it, we don't need to hardcode its value in wtf/Platform.h
Comment 3 Benjamin Poulain 2013-03-18 12:20:03 PDT 
Comment on attachment 193600 [details]
Patch

I guess you only build with build-webkit?
Comment 4 Alberto Garcia 2013-03-19 03:03:26 PDT 
(In reply to comment #3)
> (From update of attachment 193600 [details])
> I guess you only build with build-webkit?

Exactly
Comment 5 WebKit Review Bot 2013-03-19 10:54:58 PDT 
Comment on attachment 193600 [details]
Patch

Clearing flags on attachment: 193600

Committed r146222: <http://trac.webkit.org/changeset/146222>
Comment 6 WebKit Review Bot 2013-03-19 10:55:01 PDT 
All reviewed patches have been landed.  Closing bug.