SSIA. EwkPageGroup is just a wrapper around WKPageGroupRef, hence there is no reason in keeping several different EwkPageGroup instances for the same WKPageGroupRef. Secondly EwkPageGroup should take after EwkContext::createOrFindWrapper API to keep consistency.
Created attachment 193183 [details] patch
Comment on attachment 193183 [details] patch LGTM
Looks fine to me, too.
Comment on attachment 193183 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=193183&action=review > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:35 > + RefPtr<EwkPageGroup> pageGroup = pageGroupRef ? EwkPageGroup::findOrCreateWrapper(pageGroupRef) : EwkPageGroup::create(); argh! here is a mistake: We should let page group to be null (at the moment we have the same mistake inside EwkPageGroup::create() :( ).
Created attachment 193311 [details] patch v2 Fixes also default page group usage problem.
(In reply to comment #5) > Created an attachment (id=193311) [details] > patch v2 > > Fixes also default page group usage problem. LGTM. This is more correct way to use the default page group created by WebContext when we pass page group as '0'. My first though was to create the default page group with the 'defaultPageGroupIdentifier' in EwkPageGroup but it may lead to create two WebPageGroup in this case. (one is by WebContext, and the other is by EwkPageGroup::create().)
Comment on attachment 193311 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=193311&action=review LGTM > Source/WebKit2/UIProcess/API/efl/EwkView.h:259 > RefPtr<EwkContext> m_context; > + RefPtr<WebKit::WebView> m_webView; > RefPtr<EwkPageGroup> m_pageGroup; > OwnPtr<Evas_GL> m_evasGL; Why is this move not explained in the changelog?
Committed r146075: <http://trac.webkit.org/changeset/146075>