Bug 112358 - [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
Summary: [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-14 10:11 PDT by Xabier Rodríguez Calvar
Modified: 2013-03-14 11:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.60 KB, patch)
2013-03-14 10:12 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (2.69 KB, patch)
2013-03-14 10:23 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2013-03-14 10:11:04 PDT 
[GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
Comment 1 Xabier Rodríguez Calvar 2013-03-14 10:12:00 PDT 
Created attachment 193144 [details]
Patch

Guarding with #if ENABLE(VIDEO).
Comment 2 Philippe Normand 2013-03-14 10:17:22 PDT 
Comment on attachment 193144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193144&action=review

Looks good! But please provide a changelog

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Missing change explanation...
Comment 3 Xabier Rodríguez Calvar 2013-03-14 10:23:31 PDT 
Created attachment 193145 [details]
Patch

Clarified changelog.
Comment 4 Philippe Normand 2013-03-14 10:26:57 PDT 
Comment on attachment 193145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193145&action=review

> Source/WebCore/ChangeLog:9
> +        Guarded with ENABLE(VIDEO) to prevent problems when it is not
> +        enabled.
> +
> +        Reviewed by NOBODY (OOPS!).

Reviewed by usually goes before the explanation.
Comment 5 WebKit Review Bot 2013-03-14 11:39:40 PDT 
Comment on attachment 193145 [details]
Patch

Clearing flags on attachment: 193145

Committed r145831: <http://trac.webkit.org/changeset/145831>
Comment 6 WebKit Review Bot 2013-03-14 11:39:43 PDT 
All reviewed patches have been landed.  Closing bug.