RESOLVED FIXED 112357
Roll Chromium DEPS to r188004
https://bugs.webkit.org/show_bug.cgi?id=112357
Summary Roll Chromium DEPS to r188004
WebKit Review Bot
Reported 2013-03-14 09:40:40 PDT
A DEPS roll a day keeps the build break away.
Attachments
Patch (1016 bytes, patch)
2013-03-14 09:40 PDT, WebKit Review Bot
no flags
WebKit Review Bot
Comment 1 2013-03-14 09:40:51 PDT
WebKit Review Bot
Comment 2 2013-03-14 10:13:49 PDT
Comment on attachment 193138 [details] Patch Rejecting attachment 193138 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Source/WebKit/chromium/depot_tools/ninja -C out/Release all ninja: Entering directory `out/Release' ninja: error: '../../Source/WebKit/chromium/tools/protoc_wrapper/protoc_wrapper.py', needed by 'pyproto/gpu/command_buffer/service/disk_cache_proto_pb2.py', missing and no known rule to make it Full output: http://webkit-commit-queue.appspot.com/results/17210180
Dana Jansens
Comment 3 2013-03-14 10:15:00 PDT
Is something broken in webkit or in chromium here? I couldn't roll all day yesterday either.
James Robinson
Comment 4 2013-03-14 10:35:03 PDT
dsinclair's GPU shader caching logic added a dependency from gpu/ on the protocol buffer compiler, which we don't pull in the chromium-inside-WebKit configuration. This breaks the roll. I'll see what would be necessary to pull to get this working again, hopefully it's not much.
Dana Jansens
Comment 5 2013-03-14 11:23:55 PDT
thanks james.
WebKit Review Bot
Comment 6 2013-03-14 12:15:57 PDT
Comment on attachment 193138 [details] Patch Clearing flags on attachment: 193138 Committed r145835: <http://trac.webkit.org/changeset/145835>
WebKit Review Bot
Comment 7 2013-03-14 12:16:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.