Bug 112353 - Web Inspector: Make Source Frame & status bar a layout boundary
Summary: Web Inspector: Make Source Frame & status bar a layout boundary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-14 08:30 PDT by Andrey Lushnikov
Modified: 2013-04-02 11:36 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2013-03-14 08:44 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (13.09 KB, patch)
2013-03-18 03:04 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (6.18 KB, patch)
2013-04-02 10:04 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (6.21 KB, patch)
2013-04-02 11:03 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-14 08:30:34 PDT 
Make source frame & status bar a layout boundary. This will improve text editing performance, because edits make editor to invalidate its dom and update source position element, which is located in status bar.
Comment 1 Andrey Lushnikov 2013-03-14 08:44:17 PDT 
Created attachment 193129 [details]
Patch
Comment 2 Pavel Feldman 2013-03-14 12:45:11 PDT 
Comment on attachment 193129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193129&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:697
> +        this.element.style.height = this.element.parentElement.offsetHeight + "px";

We could do this for all views that use "fill" style. I.e. we make all views have a "view" classname and for  ".view .fill" we make it a boundary. "fill" guarantees absolute positioning, so .view .fill would need to add width: 100%, overflow and you take care of the height here. So you magically fix everything at once.

> Source/WebCore/inspector/front-end/inspector.css:53
> +    /* position must be relative or absolute */

You could set position: relative here since it is not affecting the layout by default. And you could specify the height of 300px so that clients were forced to override it.
Comment 3 Andrey Lushnikov 2013-03-18 03:04:45 PDT 
Created attachment 193512 [details]
Patch
Comment 4 Pavel Feldman 2013-03-19 10:01:38 PDT 
Comment on attachment 193512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193512&action=review

> Source/WebCore/inspector/front-end/CSSNamedFlowCollectionsView.js:44
> +    this.fillElement();

fillParent

> Source/WebCore/inspector/front-end/View.js:153
> +            this.element.style.height = "";

style.removeProperty("height")

> Source/WebCore/inspector/front-end/inspector.css:36
> +    overflow: hidden;

What about views that contain large elements (and hence have overflows?)
Comment 5 Andrey Lushnikov 2013-04-02 10:04:27 PDT 
Created attachment 196170 [details]
Patch
Comment 6 Pavel Feldman 2013-04-02 10:55:10 PDT 
Comment on attachment 196170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196170&action=review

> Source/WebCore/inspector/front-end/View.js:157
> +            this.element.style.height = "";

removeProperty
Comment 7 Andrey Lushnikov 2013-04-02 11:03:22 PDT 
Created attachment 196185 [details]
Patch
Comment 8 WebKit Review Bot 2013-04-02 11:36:07 PDT 
Comment on attachment 196185 [details]
Patch

Clearing flags on attachment: 196185

Committed r147478: <http://trac.webkit.org/changeset/147478>
Comment 9 WebKit Review Bot 2013-04-02 11:36:11 PDT 
All reviewed patches have been landed.  Closing bug.