Bug 112337 - Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
Summary: Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-14 03:10 PDT by Ilya Tikhonovsky
Modified: 2013-03-14 06:38 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2013-03-14 03:21 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-03-14 03:10:54 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2013-03-14 03:21:06 PDT 
Created attachment 193099 [details]
Patch
Comment 2 Yury Semikhatsky 2013-03-14 05:33:07 PDT 
Comment on attachment 193099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193099&action=review

> Source/WebCore/inspector/front-end/FlameChart.js:224
> +            this._xScaleFactor = --this._xScaleFactor > minXScaleFactor ? this._xScaleFactor : minXScaleFactor;

if (--this._xScaleFactor < minScaleFactor)
    this._xScaleFactor = minScaleFactor;

Also this._xScaleFactor is a floating point number, should it be int?
Comment 3 Ilya Tikhonovsky 2013-03-14 06:35:27 PDT 
(In reply to comment #2)
> (From update of attachment 193099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193099&action=review
> 
> > Source/WebCore/inspector/front-end/FlameChart.js:224
> > +            this._xScaleFactor = --this._xScaleFactor > minXScaleFactor ? this._xScaleFactor : minXScaleFactor;
> 
> if (--this._xScaleFactor < minScaleFactor)
>     this._xScaleFactor = minScaleFactor;
> 
> Also this._xScaleFactor is a floating point number, should it be int?

Actually it has to be 2^n where n could be negative.
Comment 4 Ilya Tikhonovsky 2013-03-14 06:38:22 PDT 
Committed r145807: <http://trac.webkit.org/changeset/145807>