Bug 112321 - Web Inspector: [Network] Sort columns context menu items alphabetically.
Summary: Web Inspector: [Network] Sort columns context menu items alphabetically.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 23:02 PDT by Eugene Klyuchnikov
Modified: 2013-03-15 01:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2013-03-13 23:12 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (5.18 KB, patch)
2013-03-14 06:23 PDT, Eugene Klyuchnikov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-03-13 23:02:39 PDT 
Columns are presented in "natural" order -> it is hard to find specific item.
Comment 1 Eugene Klyuchnikov 2013-03-13 23:12:09 PDT 
Created attachment 193068 [details]
Patch
Comment 2 Pavel Feldman 2013-03-13 23:36:51 PDT 
Comment on attachment 193068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193068&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:996
> +            var title1 = columns[id1].name || columns[id1].title || "";

You should sort by title, not name.
Comment 3 Eugene Klyuchnikov 2013-03-14 02:53:03 PDT 
Comment on attachment 193068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193068&action=review

>> Source/WebCore/inspector/front-end/NetworkPanel.js:996
>> +            var title1 = columns[id1].name || columns[id1].title || "";
> 
> You should sort by title, not name.

Objection. We should sort by item title user see in menu.
Menu item title is "column.name || column.title".
This is because title could be presented with titleDOMFragment.
Comment 4 Eugene Klyuchnikov 2013-03-14 06:23:47 PDT 
Created attachment 193114 [details]
Patch
Comment 5 Eugene Klyuchnikov 2013-03-15 01:31:15 PDT 
Committed r145886: <http://trac.webkit.org/changeset/145886>