Bug 112317 – Need to use const String in HTMLVideoElement::posterImageURL

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

Need to use const String instead of  "const AtomicString&" which means we’ll do an extra hash lookup

Created attachment 193054 [details]
Patch

Created attachment 193055 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 193055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193055&action=review

r=me with correction below.

> Source/WebCore/ChangeLog:11
> +        Need to use const String instead of const AtomicString& which means we will do an extra hash lookup

We don't normally use const with local variables, so not "const String".

> Source/WebCore/html/HTMLVideoElement.cpp:320
> +    const String url = stripLeadingAndTrailingHTMLSpaces(imageSourceURL());

Should be "String", not "const String"

Created attachment 193143 [details]
Patch

Comment on attachment 193055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193055&action=review

>> Source/WebCore/ChangeLog:11
>> +        Need to use const String instead of const AtomicString& which means we will do an extra hash lookup
> 
> We don't normally use const with local variables, so not "const String".

Change to use string. thanks

[WebKit Review Bot]

Comment on attachment 193143 [details]
Patch

Clearing flags on attachment: 193143

Committed r146069: <http://trac.webkit.org/changeset/146069>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.