RESOLVED FIXED112291
run-perf-tests should support content_shell 
https://bugs.webkit.org/show_bug.cgi?id=112291
Summary run-perf-tests should support content_shell
Adam Barth
Reported 2013-03-13 14:30:22 PDT
run-perf-tests should support content_shell
Attachments
work in progress (1.65 KB, patch)
2013-03-13 14:30 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.31 KB, patch)
2013-03-13 14:37 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.38 KB, patch)
2013-03-13 14:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-03-13 14:30:34 PDT
Created attachment 192992 [details] work in progress
Adam Barth
Comment 2 2013-03-13 14:37:04 PDT
Created attachment 192997 [details] Patch
Eric Seidel (no email)
Comment 3 2013-03-13 14:39:21 PDT
Comment on attachment 192997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192997&action=review > Tools/Scripts/webkitpy/performance_tests/perftest.py:238 > + re.compile(r'INFO:SkFontHost_fontconfig.cpp'), > + re.compile(r'Running without the SUID sandbox'), You might want to mark that these are from content_shell in a comment.
jochen
Comment 4 2013-03-13 14:40:54 PDT
Comment on attachment 192997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192997&action=review >> Tools/Scripts/webkitpy/performance_tests/perftest.py:238 >> + re.compile(r'Running without the SUID sandbox'), > > You might want to mark that these are from content_shell in a comment. Or just install the SUID sandbox... https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment
Adam Barth
Comment 5 2013-03-13 14:45:54 PDT
> Or just install the SUID sandbox... https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment That would solve the problem for me, but other folks would run into the error.
Adam Barth
Comment 6 2013-03-13 14:46:47 PDT
Created attachment 192998 [details] Patch for landing
jochen
Comment 7 2013-03-13 14:47:51 PDT
Doesn't the error include the link how to fix it? I think the idea is that running any browser without a sandbox is bad. However, since content_shell in DRT mode doesn't allow outgoing connections anyway, I guess it doesn't really matter.
Adam Barth
Comment 8 2013-03-13 15:02:41 PDT
> Doesn't the error include the link how to fix it? Yes, but I want to run performance tests, not fix configurations problems. :) > However, since content_shell in DRT mode doesn't allow outgoing connections anyway, I guess it doesn't really matter. Maybe I should fix it, but it should block me from profiling "<html>".
WebKit Review Bot
Comment 9 2013-03-13 15:36:24 PDT
Comment on attachment 192998 [details] Patch for landing Clearing flags on attachment: 192998 Committed r145764: <http://trac.webkit.org/changeset/145764>
WebKit Review Bot
Comment 10 2013-03-13 15:36:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.